Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] serial: amba-pl011: add RS485 support
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     Greg KH <gregkh@linuxfoundation.org>, linux@armlinux.org.uk,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210618145153.1906-1-LinoSanfilippo@gmx.de>
 <YNSA1H0cFKiPUn6N@kroah.com> <5d7a4351-2adc-ea31-3290-91d91bd5a5d4@gmx.de>
 <db436292-4115-0755-57d8-d63986f84453@kernel.org>
 <trinity-163a08b4-6e39-4d15-bde2-815342f13fc4-1624620116191@3c-app-gmx-bs05>
 <a89dec92-e764-c833-bbeb-ba3d84381e78@kernel.org>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <5c249dfc-90a6-7724-e884-9516aaf829fb@gmx.de>
Date:   Tue, 29 Jun 2021 11:46:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <a89dec92-e764-c833-bbeb-ba3d84381e78@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


Hi,

On 26.06.21 at 05:41, Jiri Slaby wrote:

> On 25. 06. 21, 13:21, Lino Sanfilippo wrote:
>> Thats right, the logic has slightly changed. I thought this does not ma=
tter as long as
>> we make sure that exactly one of both ON_SEND or AFTER_SEND is set.
>
> I actually don't know. But I would remain consistent with other drivers.
>
>> We can stick with the logic
>> in serial8250_em485_config() (i.e. always set ON_SEND and delete AFTER_=
SEND in case
>> of an invalid setting), but I think this will require more than the fou=
r lines that we
>> have now (especially if we want to avoid the !!).
>
> What if you used only a single !?
>

You are right, this is the easiest way to keep the current logic. I will d=
o that.

Thanks,
Lino