Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in
 radeon_user_framebuffer_create()
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>,
        alexander.deucher@amd.com, airlied@linux.ie, daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20210629114455.12963-1-jingxiangfeng@huawei.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <5ff91e15-6014-bc72-40ca-3fa8b834f692@amd.com>
Date:   Tue, 29 Jun 2021 13:42:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20210629114455.12963-1-jingxiangfeng@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:acb7:5516:6a55:2bf5] (2a02:908:1252:fb60:acb7:5516:6a55:2bf5) by PR0P264CA0142.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Tue, 29 Jun 2021 11:42:22 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cc92c463-8598-4194-cbd2-08d93af2f64e
X-MS-TrafficTypeDiagnostic: MN2PR12MB3774:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MN2PR12MB377482601007A1CA8F42B76B83029@MN2PR12MB3774.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: T05zHbcNcoIFGNvwW0y9z6qxupxVDFXNnRi5/aS1QHAcNcOpENvx8f59I1SjggPrYqk7LRMQv/aPHkSebPwh6PYhKgbj0YKdD3KgeS6ljSmsQXjalwYUnuwSLC+ilHEho6jEDcZt/sO7jNpUArt+eX4iybAKvvfnLgUyTwCAVdtyUDa6L6TLlLgkIjXDf3XgTN4Eqt2Nn7DEcS1Prys/aYAmUPNt+ZqfPA/c0ZnkDzKBqXGXJDIhH+skw8902tiDMTIzU26dLLTuSVeDqLvNIJYIquUPPpEPpk17rh7IAygZLu3n+IrkrhdjHce9d8qrBhQf8sJdhj5suoarGjha4sX7ty1OmpfkmM5VpTHjUSWDW9YdkO3Vv4Zd3+Tm5YsYC0XBJipCE37ToxM26r7UKxk+dwXnX3TvA9KYaImnrWOCr6lWyHDXWbOXYakQPj/Fg2XQG10SMz9uXMkYprdvTxwansxDYF6xNq8dIhHiiWQaiaglPgUfiPldnaJv2CWbUVjNkw6T6c2HeAu3TXgvlWTeGL4rodRSBbF7jw44e1/oVGCCbwguNgARgasAVKHgsXqxpaEfXWjAtFr/mn9drKYefTDXiY9AZBC4C6M0IJxRoZrN+XqtxoC/EymEyZU8H/OWaOEAzTJSZCo8SJJN5EeFuSf39sDbPbXAihEpcT4X4DezWvw+BEWhh5c5A30q6z0ru5it6qFrkCCYfScexa/K2U5LBeHGQE4czoZphcSHzs9GZg2MZA6cx4ev8OjC
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(39860400002)(366004)(376002)(136003)(4326008)(6486002)(38100700002)(8676002)(316002)(36756003)(8936002)(31696002)(478600001)(31686004)(2616005)(66946007)(66476007)(6666004)(186003)(16526019)(66556008)(86362001)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1FDc2FHbWFybUNoRnErSDBrY24vYUlBRHkydlUwNDBja0pXd2NUQ2tXdmR0?=
 =?utf-8?B?enlWVHFkby8zMXlxWXJtOG1wZFE5RE16djd2T3lHdWc3VUZZcUFxMmxHSGYr?=
 =?utf-8?B?S3FlakcwKzFiSTVNb1BkSlhtRFd5eEUzYWlubW9waEJIK1I1K0MvOENOVDFV?=
 =?utf-8?B?a1IvQ20wdGlBVlIzVmlMQWxnVlk2WWM3Vm9JMi93VHlrNmtaM1pwajZIQ3pF?=
 =?utf-8?B?SWcrbGJkQjgwelB6NkQ0ZTVtL0szQXdzSjF4OFU0eWJKa2Jsd1pxZE1MSGI5?=
 =?utf-8?B?Mm5WL1BvN2R2OUtGMkMrVmNsSnYvbm9uOVplcU9lV0hmTmpvWklLOVQrK250?=
 =?utf-8?B?UmNFZ0VQWHIzcE50SWFJWTdUWm11NlJSMnNKT0xUWUVGZG5PZDFIQXp1d1VM?=
 =?utf-8?B?MFY2ZFAyNi9jQkoxVHNLMUZEZDVaR1Qyb0NPejVNeGx1aHZiK3BVd0d1aHZ4?=
 =?utf-8?B?Y2kybjZJdmRkS1FKOG5LV1RvQ3BFY2tCd0hTSlBUSHIrUVdOUUpuaHp1a3lR?=
 =?utf-8?B?VUhSb0pRV1lpbzI5TDhPNzZSZkNSekNrS2NLeWozdEw5VXliMW13SGtDQjIv?=
 =?utf-8?B?dmVOWkEveW8xeEVFNFAzeFpFOE1CeVZJU1N5dXpybGJFUkVuM0hBRTAzU3l2?=
 =?utf-8?B?MllMMlV5S1JsMEFNRER6eWFsUDYwRVJ1eW1aQ2NkcFR0UlRTbjhHM0xpNUR0?=
 =?utf-8?B?K1h1TzdVMUI4SlNId3lPL0doR2ZHYkszdlVFVi9tRUVhRWRGZjRrMCtML2Vo?=
 =?utf-8?B?VCtMdkxYTG00UkJENWFxbWlMaHdYdnJCcG9PVk5sd2duUW1HbktnRmJkN1hB?=
 =?utf-8?B?dnRBS2h4UnBxeUpMV3lvMFJ0a1YwVjN1V2lFUTFhdTVEZUdhSlVJT2NPSkxm?=
 =?utf-8?B?MXI1MU84cmh3RWhqUDA5SlhqRzdhQmxvNXBPeWpobGxLenkyblUyc2thTlBa?=
 =?utf-8?B?NmJETUVTNlA5dk9VWE5nWTQwUGFXSlFXeFZwMGJKYjAzZ2NsWGN0RFlqdmVp?=
 =?utf-8?B?NEFKUnpNRzY0VTRhajd5d1dZdXozOGg5bUc3NmMvNGw3emdYZStDMFR2Qnow?=
 =?utf-8?B?VG1OL1BPbS9BTE81cGRTMWkyTlJUVDlSWURPSEh6MGc2YlhuOUtkWk9wMUdn?=
 =?utf-8?B?emJPcHdVUDdJZmxJS0dHWTB5VHExSkN0aVpNd2o1S1FhMWtCZWZtc0FvYWw4?=
 =?utf-8?B?MTVTZVY3Z1pjb2NrTjhiTktYNTF0bzcyTVJTRTdOMm5kM1FOTUpOL3VvMjdu?=
 =?utf-8?B?QlFPWmFPVnRtSnhjQjA2MXErUTlTQlllRThnclJDT0QwZFozMDY1b2EyODFR?=
 =?utf-8?B?Z05lcENSTEpDRnpZRkFYR3pkWk5QTng5NDhuZnJHT1VXdmpTK210Qm50QXNW?=
 =?utf-8?B?dWtONmdFRm9ydW9iQlFaQk4zTktYM2R0RmVGOENaMEFHNjlIU3NibUM5ZVRo?=
 =?utf-8?B?UzRyRnFrK3J5eEZqVW9TSDBWSHJjVDIvaW00d0hKSWptUS9aM2FpUWNOUWNE?=
 =?utf-8?B?SmNsdld1ejM1RndJamE3VmF3UHNMWXRUZGZRdlo5LzV3b1lwenVJYUhteVVs?=
 =?utf-8?B?cTdRUVlNTUZ0MzFURmJpM2NnU0FVbmRFVTR0eTRmeFl4UUUwelIveGdwVDNj?=
 =?utf-8?B?UzUrd2hycU5PeVl4dlpyWmxRZlIzOGpjeElOYWVyS1ZzdUhBb3dXUGp5ZWV6?=
 =?utf-8?B?dXl1RDg1KzdoWk8vNmQvSlJDdzBwaGJROEd4L05jdCtUM1hhK2hVSi80b0ZL?=
 =?utf-8?B?TEY5T3VtaFZaak5BbFhaRHVSaWpWcXRsYzEzRTJYaUpPQXE2Si8zbTQrZVVE?=
 =?utf-8?B?Qkx5MjY3anZlcm10cDJUOU9FRWl1TzFhLzJsTiszOWpOSUhoaE9Wd24rZWNj?=
 =?utf-8?Q?l1WnkFwuSKkwy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc92c463-8598-4194-cbd2-08d93af2f64e
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 11:42:24.0590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tVX7S/t3ew0+oJEUmo3QLk0QyQ762zVqF7dGhu84tb+pfWVTDMwSUzegpgSa+knI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3774
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> an error path. Add the missed function call to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

I'm pretty sure that I already reviewed the same patch a few weeks ago, 
but it looks like it never went upstream.

Reviewed-by: Christian König <christian.koenig@amd.com>

Maybe add CC: stable as well?

Regards,
Christian.

> ---
>   drivers/gpu/drm/radeon/radeon_display.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 652af7a134bd..1d03ec763604 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
>   	/* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
>   	if (obj->import_attach) {
>   		DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> +		drm_gem_object_put(obj);
>   		return ERR_PTR(-EINVAL);
>   	}
>