Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4335255pxv; Tue, 29 Jun 2021 04:48:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLD50jfhuBZ+MRk8QgsjP1doD734pcIJKywtqvo3MgELHuDDilq2IUHDUhf17vjGV2DRQ+ X-Received: by 2002:a92:6509:: with SMTP id z9mr21737687ilb.184.1624967293691; Tue, 29 Jun 2021 04:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624967293; cv=none; d=google.com; s=arc-20160816; b=xzfbQWgIfCqGXr0BHBA+UpLuAvV0CaF8XCAS5HlohNkFRb51J8tSrcq+oMgxkJ0frw ywZihHqFqyHa5nqyzzjry/TBK85au4wCOh3GlORCjI67W2pjA02RSS1ptR6xQT3raPId HvSLRQcW1PzzbH7y/smjBQaDWPFqXItRyAaLECpAUKxEmOAjecake+HLFEZ4ZXxbnX8H L74FKLKskVhbWr+cA2/zgxgJZB6IwzUpBRcHj2hQINVmHAO2n5uZ8mODd4cLCpGoWWyB UPrkcuR8JeLATnErnKZKj/vH1hL/InXai0Uh1tffcOcTMUYzgcppBjEe9jJRx29PBOfR av0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zvn7AanjM2wZW6ncTPeWURtZ+UvRqL12FAiUwFX5C3A=; b=pJxCZn6Yt54U04DaBN4MmJqpaT9b4IMOfbGXBGYBaLvB3j/fis4wYzu3Xgg4r2QI+H RRg9rGqgfEMHHljw6X/kqbUDqvgTp30pYBf8Uqb0kcWpQckqRpPTL2T2PQ/G4ZPNrTcX kVqIfOfZp9MdFPy81Vi/u1OCuIUE7tvnj0zEEvgOdxznCKw4MaVSjs/ImonpFM0Rv5d6 wO0MHGuFrzoE0gOitzyYALl8ULHNGYBMd7FMAg3IxLoKCtxocvaZoqrst5WJgaUVGBro q9QoM7VxmZQTF4kOm3Siwcj39LZks247YHBPtEdUzSp+6s1zdKEeYfjFn6b1fZhO2QuJ Qvqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d187si22360837iog.56.2021.06.29.04.48.00; Tue, 29 Jun 2021 04:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232760AbhF2Jcv (ORCPT + 99 others); Tue, 29 Jun 2021 05:32:51 -0400 Received: from gloria.sntech.de ([185.11.138.130]:40196 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232614AbhF2Jcv (ORCPT ); Tue, 29 Jun 2021 05:32:51 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyA4J-00023X-AF; Tue, 29 Jun 2021 11:30:11 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-rockchip@lists.infradead.org, Levin Cc: Wayne Chou , Kongxin Deng , Chen-Yu Tsai , Jagan Teki , Jensen Huang , Johan Jonker , Liang Chen , Marty Jones , Rob Herring , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v0 2/2] arm64: dts: rockchip: add support for Firefly ROC-RK3399-PC-PLUS Date: Tue, 29 Jun 2021 11:30:10 +0200 Message-ID: <3771996.aKNjEaI27c@diego> In-Reply-To: <149c2171-471e-343e-8126-38394746b044@t-chip.com.cn> References: <20210628035402.16812-1-djw@t-chip.com.cn> <20210628035402.16812-3-djw@t-chip.com.cn> <149c2171-471e-343e-8126-38394746b044@t-chip.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Levin, Am Dienstag, 29. Juni 2021, 11:15:59 CEST schrieb Levin: > Hi all, is it possible to turn on some codec mixer switch in the device > tree? I don't think that is appropriate and/or/ possible in the devicetree. Instead I think you want an Alsa UCM profile for it, see: https://github.com/alsa-project/alsa-ucm-conf/tree/master/ucm2/Rockchip Heiko > > > Currently, to hear to sound, we need to run the following commands from > the user space: > > # turn on mixer switch > > amixer -c 1 sset 'Left Mixer' on > amixer -c 1 sset 'Right Mixer' on > > # raise volume > > amixer -c 1 sset 'Output 2' 36 > > > If these settings can be embedded into device tree, and set by kernel as > initial ALSA path settings, > > user can hear the sound with zero ALSA config. That'll be great. > > > On 2021-06-28 11:54 AM, djw@t-chip.com.cn wrote: > > + > > + es8388-sound { > > + compatible = "simple-audio-card"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&hp_det_pin>; > > + simple-audio-card,name = "rockchip,es8388-codec"; > > + simple-audio-card,format = "i2s"; > > + simple-audio-card,mclk-fs = <256>; > > + > > + simple-audio-card,widgets = > > + "Microphone", "Mic Jack", > > + "Headphone", "Headphones"; > > + simple-audio-card,routing = > > + "LINPUT1", "Mic Jack", > > + "Headphone Amp INL", "LOUT2", > > + "Headphone Amp INR", "ROUT2", > > + "Headphones", "Headphone Amp OUTL", > > + "Headphones", "Headphone Amp OUTR"; > > + > > + simple-audio-card,hp-det-gpio = <&gpio2 RK_PA6 GPIO_ACTIVE_HIGH>; > > + simple-audio-card,aux-devs = <&headphones_amp>; > > + simple-audio-card,pin-switches = "Headphones"; > > + > > + simple-audio-card,cpu { > > + sound-dai = <&i2s1>; > > + }; > > + > > + simple-audio-card,codec { > > + sound-dai = <&es8388>; > > + }; > > + }; > > + > > >