Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4336096pxv; Tue, 29 Jun 2021 04:49:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwB0aHmJpIh6VV8QtfkP2ns1XE+Hvsqugazg1RC93KoN4E/RHfcqTsEzY9mSlj9OynvC2Mq X-Received: by 2002:a6b:c40d:: with SMTP id y13mr3682640ioa.78.1624967373499; Tue, 29 Jun 2021 04:49:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624967373; cv=none; d=google.com; s=arc-20160816; b=w38ESwMqFHEGwfj0G3XR2nRr+chmwqtXVuV9x41SQ7NxX2FQ/OJXCjGacPkQvHzX59 pNxQJMR4KGBt0Vt2oNVUFY0DBr+o0MGGSvt2u4Qj32B20gJxXDK5G3djhqD4XKypWZ79 ywNPL8BUZBYEJ9HxmYE4Csn8FPusr+5F1Z6OMl1eoetfjb4mCW64P9eNO0PQLhg80UmN 0Oh4DyoxpIUIpd+1Kd3sdC6pdy2VWsYIGFW+tJFLIi0/ppgxt0fHsHEs/KW00duhZ2RA PdunOGk5GjPizrrW57i35Eco+xPJHFe/a9DpgZeiYuEiwGiD3wH+ypgNBSoOW6B/rCCp 6ehg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Egp2INH24GecpOyqDXmIt9wlO7BC40kEajevlBy0j3c=; b=BumKBlD9vagRGoqPFTst+/HOVNO34Seq1vQjddYIEAslccySpGmsdQY/tOKjDH23Kk q5jndiWe7ObrFH6y22byKWSqAg2C9FzVeA7md/wkErplAwfyD1Caun5q79OliOc0FNIf mPBR3JbvBRgcgjqaGT/rms4HpADaymxiNqOh2fsc2A+SXfqWwPZw0aTGwIRB+LXTCZjo 915sgTFzXEgrKurAt/5QZvm0cHKnlutBI9Xve2yq2u3kp+CZVfHV/d6UtoR+tKHSrU62 ii6N6LhafhJWNN5DwWMLIOPLLqCocJbhXGLvO6EFxSrlflVyE3VaKb42GBbYOQra0X0F nGlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KKfflM77; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w34si21623228jal.51.2021.06.29.04.49.22; Tue, 29 Jun 2021 04:49:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KKfflM77; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232944AbhF2JrI (ORCPT + 99 others); Tue, 29 Jun 2021 05:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232850AbhF2JrH (ORCPT ); Tue, 29 Jun 2021 05:47:07 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 894CCC061574 for ; Tue, 29 Jun 2021 02:44:40 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id x16so16682104pfa.13 for ; Tue, 29 Jun 2021 02:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Egp2INH24GecpOyqDXmIt9wlO7BC40kEajevlBy0j3c=; b=KKfflM77Ww5SOuzT7DmT1GIeX0x5VOmSxBpbMVKSG367rvUR7Vs891hZ0rA8JD9LPN DILqKomfHn3hcFb271ORqCNsH8OeRsWvkJaHYPjsU3VqqDMAJZOL8SY0BDahznO0nkqP PJEd8dFPfBPPTfRTNpraJHZetghwEMyuu4Htk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Egp2INH24GecpOyqDXmIt9wlO7BC40kEajevlBy0j3c=; b=OHB/q8/osBtpfwm6bnJmPgMoqakwhwgAl8eqpwyeHt1YaU3AYBXMhg04TS6b2oYBtx m+7ZO22xkIXYm4gs9ktPd2rO31ZNX49v2WvxVPqR39yaQuqujXbyH5XrbSiVbqClJUN0 6HEnZiiT91iZu2Xli0rpeso/e92zFguuk9+nKM1OaniV6dqII9Ujo3LrL7l5Xw1ef3D1 Mi3xMNGhAnlIQRQVEx1+/ILvp4y6C7eIgviL5CtcAzPJ7Vi98+0v8nDkIg2M+JRX1urT mlDJdqeF8XuOAm0w4ACdZsMn53GqEUupJQ+5es+eGhb83O7nEE6qOrefF1fAZW8y/XWf L1Uw== X-Gm-Message-State: AOAM530WDkKJOS7sVXm0/aip+se5GtzWcsr9etsp5zJi0ghMrwsv+uFd kPMPkLBBSmcELVr9zzwjVEnNyQ== X-Received: by 2002:aa7:8090:0:b029:300:18db:4e11 with SMTP id v16-20020aa780900000b029030018db4e11mr28988541pff.22.1624959880119; Tue, 29 Jun 2021 02:44:40 -0700 (PDT) Received: from fshao-glinux.tpe.corp.google.com ([2401:fa00:1:10:ebba:3e19:7691:d53e]) by smtp.gmail.com with ESMTPSA id f15sm17891538pgg.23.2021.06.29.02.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 02:44:39 -0700 (PDT) From: Fei Shao To: lee.jones@linaro.org Cc: Fei Shao , Gene Chen , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 2/2] mfd: mt6360: Restore error message to regmap_read failure Date: Tue, 29 Jun 2021 17:43:39 +0800 Message-Id: <20210629094339.874120-2-fshao@chromium.org> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog In-Reply-To: <20210629094339.874120-1-fshao@chromium.org> References: <20210629094339.874120-1-fshao@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This adds back a missing error message for better log readability. Fixes: e84702940613 ("mfd: mt6360: Fix flow which is used to check ic exist") Signed-off-by: Fei Shao --- drivers/mfd/mt6360-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c index 6eaa6775b888..0ff8dae4536c 100644 --- a/drivers/mfd/mt6360-core.c +++ b/drivers/mfd/mt6360-core.c @@ -351,8 +351,10 @@ static int mt6360_check_vendor_info(struct mt6360_ddata *ddata) int ret; ret = regmap_read(ddata->regmap, MT6360_PMU_DEV_INFO, &info); - if (ret < 0) + if (ret < 0) { + dev_err(ddata->dev, "Failed to read device info from regmap\n"); return ret; + } if ((info & CHIP_VEN_MASK) != CHIP_VEN_MT6360) { dev_err(ddata->dev, "Device not supported\n"); -- 2.32.0.93.g670b81a890-goog