Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fs: ntfs: super: added return error value while map
 failed
To:     lijian_8010a29@163.com, clm@fb.com, josef@toxicpanda.com,
        dsterba@suse.com
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        lijian <lijian@yulong.com>
References: <20210629095333.115111-1-lijian_8010a29@163.com>
From:   Qu Wenruo <quwenruo.btrfs@gmx.com>
Message-ID: <8c9ab967-432a-5912-3e8e-25cae5b9acbf@gmx.com>
Date:   Tue, 29 Jun 2021 20:30:47 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210629095333.115111-1-lijian_8010a29@163.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Wrong subject, it's not ntfs.

On 2021/6/29 =E4=B8=8B=E5=8D=885:53, lijian_8010a29@163.com wrote:
> From: lijian <lijian@yulong.com>

Still, you guys should try to send from your yulong.com mail box, not 163.

>
> When lookup_extent_mapping failed, should return '-ENOENT'.
>
> Signed-off-by: lijian <lijian@yulong.com>

Some maintainer is OK with name like all lower letters, but at least to
my eyes, Li Jian <lijian@yulong.com> is much easier to read.

Thanks,
Qu

> ---
>   fs/btrfs/extent_map.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
> index 4a8e02f7b6c7..e9d9f2bfc11d 100644
> --- a/fs/btrfs/extent_map.c
> +++ b/fs/btrfs/extent_map.c
> @@ -305,8 +305,10 @@ int unpin_extent_cache(struct extent_map_tree *tree=
, u64 start, u64 len,
>
>   	WARN_ON(!em || em->start !=3D start);
>
> -	if (!em)
> +	if (!em) {
> +		ret =3D -ENOENT;
>   		goto out;
> +	}
>
>   	em->generation =3D gen;
>   	clear_bit(EXTENT_FLAG_PINNED, &em->flags);
>