Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4380092pxv; Tue, 29 Jun 2021 05:51:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+ZpyrDzFlKSsd1PesXA40pVfNYU1xnaz5ynsyCyxNbFc+grbgEDuIq+7tutIE9ywWozAo X-Received: by 2002:a05:6402:31f8:: with SMTP id dy24mr26322482edb.287.1624971114052; Tue, 29 Jun 2021 05:51:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624971114; cv=none; d=google.com; s=arc-20160816; b=BHUn9A7i6AHQFgzGbZ6y06Cnn0o7qETgQp0tr14R20Y8hpv9gKEXj7jyvb7iHzrQmK G74Ey28wXaE+Mzapt5/wfWxBA/mid8d93llh4YxsE4J6gSz7ewGTTQIEmta+hWOSRLZ+ EjVjWcaj0UcMbgb1T3LLT7oglQUqZl9yf6OwjxSyG/j/spwRyXPoj+sWY9oNg5V6MUY0 c+ZLFSKXU7p4QZu+0uFevF4KtKhKikeeVNl4B8YY5fJmAuJ41APZP/XxspN6qVRG5ouS Fr4CmtPFg7oKEEjJJyO5SYundzjLEurERVTBTY56VRHuQectgeI2go+wxAm98lcQOOGp xOQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=F6+8DEUDRgQ8px260MOF5Gzv5rBY1SIRaS88R6jEyCE=; b=LOTEfXc0dmhX0stvL0vCWTAyyQE1K63iD1XTVUIsyed6Nem4wmOVFJ4MpygdyUPIrp SWp85HGzBtk8+iE4vVJKDz17BlSc44Nl1W9XDVuEpGn6atz7P55HwZNZaa2100W6EtpI MnMr7Tw9X7pMhTwwkZKzL4MK773hxuMpmTVSuDT53pDL0liXglkx6MPae+yAd3U12xKp 7TZlHO9T6PqEn3YSaSRKsXXPmmde9mE82sQQbFuMBWNKelMEyJvFRfcRhq5r0hIY1CKN 7ZTfz2/fq3Sph8C5fONYfnAJsDCQdjVczHHEfHrC9K0xwGQPFY3HdmhXjGgmHTVJjCC7 6aaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LCXjf4H4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si17070266ejf.364.2021.06.29.05.51.30; Tue, 29 Jun 2021 05:51:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LCXjf4H4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232866AbhF2LvN (ORCPT + 99 others); Tue, 29 Jun 2021 07:51:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:34830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbhF2LvN (ORCPT ); Tue, 29 Jun 2021 07:51:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 26DCC61D23; Tue, 29 Jun 2021 11:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624967325; bh=F6+8DEUDRgQ8px260MOF5Gzv5rBY1SIRaS88R6jEyCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LCXjf4H4yOk3q0HSRv8xYxAJ8h+XsBRnVpk02td2SDmGlWumHfSKgIlEMJJEesszS 6TXXXLCg3JC4JqDWuGU7wJowpo7SRhsti+9hPg7m7wTe7Vn/UXCYqBuuPorZZ6hbAr uf7iIXxygV+yutRXUK6lhfLYE+slbPT4lUUID9Au1SjhMzGr4sH//CqFvZIL6+48TZ FuFdaMtJj+isc72q2cRazFvgdAqYvVZAkGKnr4cEGWlBTngWlOgvYCuKq8MJFtOzKY kxFCjkkGEgqM2rt6dgd9tt+De/0G/GWIubkm9FqoDx1KJim1ZX5pxdLZ8ZL8wgTRXD 6ZfmqEztXtgUQ== Date: Tue, 29 Jun 2021 13:48:42 +0200 From: Wolfram Sang To: Viresh Kumar Cc: Jie Deng , linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com, arnd@arndb.de, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru, rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com, u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org, yu1.wang@intel.com, shuo.a.liu@intel.com, stefanha@redhat.com, pbonzini@redhat.com Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver Message-ID: Mail-Followup-To: Wolfram Sang , Viresh Kumar , Jie Deng , linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com, arnd@arndb.de, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru, rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com, u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org, yu1.wang@intel.com, shuo.a.liu@intel.com, stefanha@redhat.com, pbonzini@redhat.com References: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> <20210629101627.kwc2rszborc3kvjs@vireshk-i7> <20210629103014.nlk3mpetydc4mi6l@vireshk-i7> <20210629105649.nt63mxtiy6u7de3g@vireshk-i7> <20210629111630.badum3mtumcujbyk@vireshk-i7> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2NUNxijQCUO6OTHP" Content-Disposition: inline In-Reply-To: <20210629111630.badum3mtumcujbyk@vireshk-i7> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2NUNxijQCUO6OTHP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Obviously, I don't know much about the specs and their wording. Still I > > wonder if we can't call it a zero length transfer? >=20 > Maybe that. I'd prefer it. > > This is allowed by > > the I2C standard and SMBus has even a proper name for it (SMBUS_QUICK). > > From my point of view, I would not say it is device specific because > > devices are expected to ACK such a message. >=20 > Actually we should skip the last line from my diff, i.e. completely > drop "and result for such a request is I2C device specific". Sounds good. > The device (host in virtio spec terminology) still needs to return > success/failure as it does for other requests. Nothing special here. Ack. --2NUNxijQCUO6OTHP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmDbCJYACgkQFA3kzBSg KbbW8BAAsq+m8PYVjLol2Bl88/uwq+wQriAFwSj35UISp/uiVClJAokC9pPHqdwB JFehttLuSQk7F7znOXvNMauGFiCqbNO2fwfEhqHSBPCcm6kouj0LscE9GxvYYCf4 7LC9WmA2DWJlkTcutZqdhWnUSekihMCpoPBVMG4VoQmKuFaucbRBWA/hlGSYEn/j LXwJkNSvoTDScYUtHiX5CzQCq4m7ejCJ9ytsxvfu6gFpCO7UYwpvAqXr9RaulJns 7dg6JkNQX0Mpzwnn0uRcHW08KP7c//LDJH0V4kwZMZI8KSpgiRIfqlZJdSHDInRt CTZLMu0Lk/q/Nr49SteaXy40KH/emyqkSQVt36xPcXeyTZcKLuuMX02hl+aviwuG jBn1xIFaQuxBfGkFqfeZ3l/F91xzc902YyeXYVFZi98znVKttMZMY2z2lKMrwSQf YfAPWfLVtYv/FHYoMwOiOq7CIlzVknk2Tu5a1WtUcjbEXHED/OrU7wN8tr1ymTXz OxKFd1DjwX+iPVmBULxaU//JkkN0loKc2bE8pRWR59TpT84vkg0DvdHr2D4wAVLM jr5qZ1J1sknWq22ILbrcLw80LOizpOFoFE5+Pelz9DDyKG7p/qJ7geXJxWPXaExR osMWrF9lQ3EcUZ7Y58fLjViMxrdOemVzaxCnzgy6Wj4zfjqjIlI= =tZM2 -----END PGP SIGNATURE----- --2NUNxijQCUO6OTHP--