Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JBvzAZahAOEvsh6mmVA2ZRbv/tCcu4/E5KNWwpoEZn8d/Iq4ZpOCS7dOhuGTiF+N+0Dj5RyLPH
 aMu89OkwOD5CZGXe4BdMS/Rrn+g+vPa8k1AHziSsDc1SgKuSuyHznhFVOsot5F5TbEeca9bvvJ
 pkjBRYF4PfDHeiz/QQABkmk5y4pSXSh2o9aRbBzthDXqUnWqTkL1TubNLBZx5rlEi4TNrx2lrn
 rz4xTxCUVmGDySxUs0VTCM8ZEJkyVOAnaRrRbCnAZLfbdbToCue8vXTFtOZ+O2UdkZhMhSzH6Y
 Fn0=
From:   Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To:     "lijian_8010a29@163.com" <lijian_8010a29@163.com>,
        "clm@fb.com" <clm@fb.com>,
        "josef@toxicpanda.com" <josef@toxicpanda.com>,
        "dsterba@suse.com" <dsterba@suse.com>
CC:     "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        lijian <lijian@yulong.com>
Subject: Re: [PATCH] fs: ntfs: super: added return error value while map
 failed
Thread-Topic: [PATCH] fs: ntfs: super: added return error value while map
 failed
Thread-Index: AQHXbNNBVURHEYpyLkufB3xqYcL04A==
Date:   Tue, 29 Jun 2021 13:10:50 +0000
Message-ID: <PH0PR04MB7416746F354376654DD601869B029@PH0PR04MB7416.namprd04.prod.outlook.com>
References: <20210629095333.115111-1-lijian_8010a29@163.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AYXkTXjfL9mLwgyoy5BM4mnNZAK+gaGTkKq5GE7I+eQGFZzYWQGhorKRMdX+?=
 =?us-ascii?Q?T0ch4lZszsAgYSPXVZX8MQ9R+kTEtqegSTC4yPYj8r2dHe3/GiwyzS5xfcoC?=
 =?us-ascii?Q?Io+cNj8LzDCnstIuk7XOOB4OTmpfIGN56b3yvOjtP+LTMizCNXgHJv3LBAhL?=
 =?us-ascii?Q?NqJ/Rkwv5hjJHcOayQpl5hdVG5aWOn8AUzFv6vI8LeNsaX7mV+QQYLPanJz2?=
 =?us-ascii?Q?9xGxFGIKDmQIGdvBYnj3xzSpcACMCB0l+aY2WO3RfQCsYVvTCtXAvZvXLxMT?=
 =?us-ascii?Q?pGrnrLLkPaCjGobf3eKW1UJPvWy3ecNmQ+AFPhbu4KJpu0dsaL0u7J0UGeuI?=
 =?us-ascii?Q?Iq90rx0WOKRxog7ra+vGGFjkVLxHViPiut9YLf0EK2+7MZvVV8pm+5AH0QY+?=
 =?us-ascii?Q?GIOfGbx9oeyiWHELGUVdCdii4N9OJ8SOfEVnNjSR8WIBUeM1oFmVP512hdVZ?=
 =?us-ascii?Q?+CxD228PZ9vkjP4id1DcEJve5eItzK4L4o+dR1JRZC8cEBIwQ16m+fYt25ZK?=
 =?us-ascii?Q?6dzVM4pwfpX/wakj5r/jSb36tr++PRDM3auOD0Aai2JDbdeZfnQszdXH3QWK?=
 =?us-ascii?Q?ZVxrzwvPI6Tr25pWzy9+DG8KBv9sV0MtlpGeYmpzbYJebL6uXCBFOSgsycXz?=
 =?us-ascii?Q?Mr62kwDcjWZsPRrABJuOfDcBdO6XGgDCZaKBdDU+bzhYQ0OMO1I/zftFQIGM?=
 =?us-ascii?Q?qSCwTJg37fNFgW6Ryw2Ck5J3pP3HSX6pPTdKxqR8xfF+ZaZYnox4VCwkaG8A?=
 =?us-ascii?Q?m3w+V7ff5cixkjBRr41lwW0wIHN1/I7wjxfXOVNlb1N1fquysN1QWRVfrNOb?=
 =?us-ascii?Q?14T5QQ2/lVmlIkjJKjg65MuAQO8HL/rv3Z0BF8PHCpJ82WpcurltwBzkCLdT?=
 =?us-ascii?Q?08i6Y0Fr929z1NXcbzkvaZWTjCpHqmZQHuGAGEf3CsFcBaUIu2eg4gdUvRWQ?=
 =?us-ascii?Q?pqn20QQ9kRhY+jfGufR4xXKFggl3zA8cpJ0iLstdwMwilrHJekj7t6lNQe6y?=
 =?us-ascii?Q?3tP7R2X1LmGFpVy3ZsZ/hxD0eLhSACmpiCnwHJ1a7544rRCBkHHoRhwOtBmb?=
 =?us-ascii?Q?hArsa3b4Vfi1dgYSvEIlHmIhYlCDuTCuClSvtdVVOTxOw4KveyVfe856PHdK?=
 =?us-ascii?Q?PuFhUVgZo1XCuXpKhfhSXSYG4M0ItenmBlJzyRntBA8kTxyabc6cdNhi92lA?=
 =?us-ascii?Q?BRMXOul+ypbY3H+XDLz9Vxb7KWgjNYzBdlO/Ev5FVh5e3f18PQTSRxsOZUpi?=
 =?us-ascii?Q?Vv9ZTJmZuc9Zw+SPgXqLb0TaJygKeYSRQIWf6oX4bfjIMwBNp2BqfJOGOVm2?=
 =?us-ascii?Q?gdBFEws2xqWKTEh9toeROwhIKsCgU+in8v1ZssQ+kFf4fA53KIKeanfaeJZA?=
 =?us-ascii?Q?jg8B8CJnA87WrpF8bSscOQhK8CFz?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7416.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30ba985c-a53c-431c-db71-08d93aff5179
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 13:10:50.6263
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wKTSShakP6PWpcsIsuR30p5ThumuK1DVqh2HfwrxqoLs956ICeeSGCAbsFk/aeRbiZGCoiD5O7f8FUYSj9cKZ0d2narMGX3RbdhimSr9BMs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7144
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 29/06/2021 12:41, lijian_8010a29@163.com wrote:=0A=
> From: lijian <lijian@yulong.com>=0A=
> =0A=
> When lookup_extent_mapping failed, should return '-ENOENT'.=0A=
> =0A=
> Signed-off-by: lijian <lijian@yulong.com>=0A=
> ---=0A=
>  fs/btrfs/extent_map.c | 4 +++-=0A=
>  1 file changed, 3 insertions(+), 1 deletion(-)=0A=
> =0A=
> diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c=0A=
> index 4a8e02f7b6c7..e9d9f2bfc11d 100644=0A=
> --- a/fs/btrfs/extent_map.c=0A=
> +++ b/fs/btrfs/extent_map.c=0A=
> @@ -305,8 +305,10 @@ int unpin_extent_cache(struct extent_map_tree *tree,=
 u64 start, u64 len,=0A=
>  =0A=
>  	WARN_ON(!em || em->start !=3D start);=0A=
>  =0A=
> -	if (!em)=0A=
> +	if (!em) {=0A=
> +		ret =3D -ENOENT;=0A=
>  		goto out;=0A=
> +	}=0A=
>  =0A=
>  	em->generation =3D gen;=0A=
>  	clear_bit(EXTENT_FLAG_PINNED, &em->flags);=0A=
> =0A=
=0A=
You'll still need to properly handle the returned error in the caller,=0A=
otherwise this patch makes no sense at all.=0A=
=0A=
Also the subject should be something like "btrfs: handle failures from unpi=
n_extent_cache" or=0A=
sth. like this.=0A=