Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Jun 2021 15:58:23 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Harini Katakam <harini.katakam@xilinx.com>
Cc:     robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, steen.hegelund@microchip.com,
        bjarni.jonasson@microchip.com, ioana.ciornei@nxp.com,
        likaige@loongson.cn, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        harinikatakamlinux@gmail.com, michal.simek@xilinx.com,
        radhey.shyam.pandey@xilinx.com
Subject: Re: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock
 delay definitions
Message-ID: <YNsm/0dmpBgO8mqr@lunn.ch>
References: <20210629094038.18610-1-harini.katakam@xilinx.com>
 <20210629094038.18610-2-harini.katakam@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210629094038.18610-2-harini.katakam@xilinx.com>
Precedence: bulk

On Tue, Jun 29, 2021 at 03:10:36PM +0530, Harini Katakam wrote:
> Add RGMII clock delay definitions in mscc-phy-vsc8531 header.
> 
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>  include/dt-bindings/net/mscc-phy-vsc8531.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/dt-bindings/net/mscc-phy-vsc8531.h b/include/dt-bindings/net/mscc-phy-vsc8531.h
> index 9eb2ec2b2ea9..242eb4c7ede9 100644
> --- a/include/dt-bindings/net/mscc-phy-vsc8531.h
> +++ b/include/dt-bindings/net/mscc-phy-vsc8531.h
> @@ -28,4 +28,13 @@
>  #define VSC8531_FORCE_LED_OFF           14
>  #define VSC8531_FORCE_LED_ON            15
>  
> +#define VSC8531_RGMII_CLK_DELAY_0_2_NS	0
> +#define VSC8531_RGMII_CLK_DELAY_0_8_NS	1
> +#define VSC8531_RGMII_CLK_DELAY_1_1_NS	2
> +#define VSC8531_RGMII_CLK_DELAY_1_7_NS	3
> +#define VSC8531_RGMII_CLK_DELAY_2_0_NS	4
> +#define VSC8531_RGMII_CLK_DELAY_2_3_NS	5
> +#define VSC8531_RGMII_CLK_DELAY_2_6_NS	6
> +#define VSC8531_RGMII_CLK_DELAY_3_4_NS	7

Using defines like this is no longer used. Please specify the delay in
pS and convert to a register value within the driver.

   Andrew