Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4447618pxv; Tue, 29 Jun 2021 07:16:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMxERdvsj/mIFd/zaqAGNteQVASASyAQy6xOZ6NZWfcR3+YyLxiWvaJJkcXsher2NsyQev X-Received: by 2002:aa7:c891:: with SMTP id p17mr27661994eds.225.1624976189526; Tue, 29 Jun 2021 07:16:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624976189; cv=none; d=google.com; s=arc-20160816; b=x3Q3RZ2iA99mgQ5DsRt4M+4njhBB3oFerSZ7+tjaP+XLFolMW7NJBiefmf95uYnArL 26e9mTOupJXdC+GJWwaTtgh8spmDvG/d92GutCBJuuMqqoBTaLA9zQAFTbKG+0LptqxF Hqr7o5ISqoPeziaL1DJk7g9pNx98siiF+QQY/fP9GUDLrxweFqxrKJZ//GX0w0a6edWA xMWe/Hvh5rleu9lgBDyb4Q2KmCRTpCdBL2yXmb6Y9LzKg+bky7gtdM/argLDTYAvkMLU eMLYbVyszF9qGsp7eF8FVbDrnSmQJGMvZfPQgr632NWxuzN3JfKjX+MTAiviJWUzK7Pu Vuxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DlisRa0Lh5ZDcC0aA7CRmD4wVeWJekk5S8eo2LllnQc=; b=eHWfIdQzPwuryZ8o84g3jhVND73VqsAzVRzyt4M0rPky1Z55Bi2hz7Flt9kfhh0dvn LwhA9wL9UE1sp0WZ0ynYEcEYe2cs2PQ/c0s07EDdlfgJsWjZOSd7f6ruJ7shIBmjHOIS /ssM7hjBlfNSnoR0r49ajpEFdy0xS6bVZPP+hbEWqDV6B8oM/H7azlYeZQZDHk4ty5re cH8xwGul8QoLbPCnNjmON9LyePV9xDTpsUUGi3dEHHjCzyqix87UBxpsUcpho5ab2h9K 65qo6ZqEYCLhHbpY2SVeQWnXLXcH+DRsOr/7i4IcUGJdSIto7uKtUB4kMA93Jlsp6W++ C7pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=fMk0eclu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w1si17911375edu.473.2021.06.29.07.16.06; Tue, 29 Jun 2021 07:16:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=fMk0eclu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234361AbhF2OOb (ORCPT + 99 others); Tue, 29 Jun 2021 10:14:31 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:53862 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234330AbhF2OO3 (ORCPT ); Tue, 29 Jun 2021 10:14:29 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 03B72226AB; Tue, 29 Jun 2021 14:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624975921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DlisRa0Lh5ZDcC0aA7CRmD4wVeWJekk5S8eo2LllnQc=; b=fMk0ecluwK7phJjKD9C3ZylkpTsyXs8oYN5zeMO/FPdQAPqjA7vhETF42T/F1zjHVJbPl9 NuG+i0qntP33K2L/zVXmoz1Qk1zPJUmvcNce1m+gpZd3eMffJvVExv5o9Q+9jBlcCSaCJ5 39DzkZtx4ptmQv2P2f1W0TaA83Cc9+U= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C75B2A3C42; Tue, 29 Jun 2021 14:12:00 +0000 (UTC) Date: Tue, 29 Jun 2021 16:11:59 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: Mel Gorman , Andrew Morton , Matthew Wilcox , Rafael Aquini , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmalloc: add cond_resched() in __vunmap() Message-ID: References: <20210622225030.478384-1-aquini@redhat.com> <20210624142339.GA2267@pc638.lan> <20210625160011.GA50201@pc638.lan> <20210628164002.GA11817@pc638.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628164002.GA11817@pc638.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 28-06-21 18:40:02, Uladzislau Rezki wrote: > Also another option can be: > > if a pcp list is fully consumed, so a refilling is required to proceed with array > populating, leave atomic section(enable irq), do a breath by invoking cond_resched()? I do not know. I would rather not medle with the pcp batches. It is a hot path and caller can decide the fallback mechanism. -- Michal Hocko SUSE Labs