Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210629094038.18610-1-harini.katakam@xilinx.com>
 <20210629094038.18610-4-harini.katakam@xilinx.com> <453afad0-4e4b-f1bf-6ec5-5675d2c9c1b6@gmail.com>
In-Reply-To: <453afad0-4e4b-f1bf-6ec5-5675d2c9c1b6@gmail.com>
From:   Harini Katakam <harinik@xilinx.com>
Date:   Tue, 29 Jun 2021 19:49:26 +0530
Message-ID: <CAFcVECK2COLnkr+7+4FKKn6anDPERsmxcVWsfwpBWnEXdD8KzQ@mail.gmail.com>
Subject: Re: [PATCH 3/3] phy: mscc: Add support for VSC8531_02 with RGMII tuning
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Harini Katakam <harini.katakam@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        linux@armlinux.org.uk, David Miller <davem@davemloft.net>,
        kuba@kernel.org, steen.hegelund@microchip.com,
        bjarni.jonasson@microchip.com, ioana.ciornei@nxp.com,
        likaige@loongson.cn, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Michal Simek <michal.simek@xilinx.com>,
        radhey.shyam.pandey@xilinx.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Heiner,

On Tue, Jun 29, 2021 at 4:11 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 29.06.2021 11:40, Harini Katakam wrote:
> > Add support for VSC8531_02 (Rev 2) device.
> > Add support for optional RGMII RX and TX delay tuning via devicetree.
> > The hierarchy is:
> > - Retain the defaul 0.2ns delay when RGMII tuning is not set.
> > - Retain the default 2ns delay when RGMII tuning is set and DT delay
> > property is NOT specified.
> > - Use the DT delay value when RGMII tuning is set and a DT delay
> > property is specified.
> >
> > Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > ---
> >  drivers/net/phy/mscc/mscc.h      |  3 +++
> >  drivers/net/phy/mscc/mscc_main.c | 41 ++++++++++++++++++++++++++++++--
> >  2 files changed, 42 insertions(+), 2 deletions(-)
> >
<snip>
>  {
> >       .phy_id         = PHY_ID_VSC8540,
> >       .name           = "Microsemi FE VSC8540 SyncE",
> > @@ -2668,6 +2704,7 @@ static struct mdio_device_id __maybe_unused vsc85xx_tbl[] = {
> >       { PHY_ID_VSC8514, 0xfffffff0, },
> >       { PHY_ID_VSC8530, 0xfffffff0, },
> >       { PHY_ID_VSC8531, 0xfffffff0, },
> > +     { PHY_ID_VSC8531_02, 0xfffffff0, },
>
> Effectively this is the same as the line before. Maybe it would make sense
> to change this table in a follow-up patch to just one entry covering all
> PHY ID's with the vendor part being Microsemi, e.g. using macro
> PHY_ID_MATCH_VENDOR().

Thanks for the review. Let me check and test - I have a couple of these parts.
Will try to include the patch in this series.

Regards,
Harini