Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4471363pxv; Tue, 29 Jun 2021 07:48:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXCVeQ5vJLX+CwNmIZ6Dis2EootpDHaW8UtB2ix2p+Z0WtpQoYW0DiWy4GQ90lDnsVUg/I X-Received: by 2002:a17:906:4e4f:: with SMTP id g15mr5464425ejw.217.1624978103949; Tue, 29 Jun 2021 07:48:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624978103; cv=none; d=google.com; s=arc-20160816; b=n+XKpvW0qr+9GNFNfsK4B0hoFlgE9y1BGIlySoMB/d4CGB95jOPjI2rzLlkTgHleoN IDpR8SrCg9z3w2kfnormwAnt4l6WttgkS5J1UBVstuuBlBTYsoaenpimxHYaIdDDquYb ILyEPj6wEn0gnOnyjV3Eii8uQmfJ/w0QeQvW9SE5gURceIFMYrdQPYNL6XT+W7u9ZnN6 ZaoJnkOuxHTKi6RXLRWdCrDpuXNNs0igy4+Xn1yJT0HczHBvhn7ohAHaMqin6cU21HoY Iv4y+JcBoHdraq7+tk7lmfH9nVhBM9EXuRd8M8F7MK5QZygbI7p7ZZJP5TEL0CLMT9O/ 695Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:to:subject; bh=q+Qu+0rYcoHCa85HF4478ZD9d2nV6Ms1khW5n3/D1dg=; b=GMBFxdx2RbAspyl6qLLjiNMXsDCUv3r5Jkyfg7dbDbmKNNwBJ3lob+aro3pO0aHNsj MpU30vSklau2joeaso0Hr06wa1+N7FKNAXwpRkoyIA1O+55unD799MOndkrVJUxpWHo7 DNlmJa1lM/hZlVcn8r2NoujD+Paa3EU1Su+249NbfZZndcov3ef+Z5yliBNHN1C8lYgu X/joLHd9099g3f8uy/enlYi06LxTYRiVCqW4SL/leVPjM20kFjFAO72GPUkU73XuuJ6S EhoLUaHscXfzrk9qRP40ZTspeFstNS5YG55thONRfTsIEIp/dKtmN0ji2O7w/EXEge+3 4C/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp16si22195574ejc.434.2021.06.29.07.48.00; Tue, 29 Jun 2021 07:48:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234470AbhF2Os6 (ORCPT + 99 others); Tue, 29 Jun 2021 10:48:58 -0400 Received: from mga14.intel.com ([192.55.52.115]:57681 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232790AbhF2Os5 (ORCPT ); Tue, 29 Jun 2021 10:48:57 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="207979693" X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="207979693" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 07:46:29 -0700 X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="643736591" Received: from bzhang2-mobl1.amr.corp.intel.com (HELO [10.255.231.86]) ([10.255.231.86]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 07:46:28 -0700 Subject: Re: [syzbot] BUG: sleeping function called from invalid context in __fdget_pos To: syzbot , bp@alien8.de, hpa@zytor.com, jpa@git.mail.kapsi.fi, kan.liang@linux.intel.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, syzkaller-bugs@googlegroups.com, tglx@linutronix.de, x86@kernel.org, Ard Biesheuvel , Herbert Xu References: <000000000000f3e94a05c5d8686f@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Tue, 29 Jun 2021 07:46:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <000000000000f3e94a05c5d8686f@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... adding Ard who was recently modifying some of the kernel_fpu_begin/end() sites in the AESNI crypto code. On 6/28/21 12:22 PM, syzbot wrote: > console output: https://syzkaller.appspot.com/x/log.txt?x=170e6c94300000 > kernel config: https://syzkaller.appspot.com/x/.config?x=42ecca11b759d96c > dashboard link: https://syzkaller.appspot.com/bug?extid=5d1bad8042a8f0e8117a > > Unfortunately, I don't have any reproducer for this issue yet. ... > BUG: sleeping function called from invalid context at kernel/locking/mutex.c:938 > in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 29652, name: syz-executor.0 > no locks held by syz-executor.0/29652. > Preemption disabled at: > [] kernel_fpu_begin_mask+0x64/0x260 arch/x86/kernel/fpu/core.c:126 > CPU: 0 PID: 29652 Comm: syz-executor.0 Not tainted 5.13.0-rc7-syzkaller #0 There's a better backtrace in the log before the rather useless backtrace from lockdep: > [ 1341.360547][T29635] FAULT_INJECTION: forcing a failure. > [ 1341.360547][T29635] name failslab, interval 1, probability 0, space 0, times 0 > [ 1341.374439][T29635] CPU: 1 PID: 29635 Comm: syz-executor.0 Not tainted 5.13.0-rc7-syzkaller #0 > [ 1341.374712][T29630] FAT-fs (loop2): bogus number of reserved sectors > [ 1341.383571][T29635] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > [ 1341.383591][T29635] Call Trace: > [ 1341.383603][T29635] dump_stack+0x141/0x1d7 > [ 1341.383630][T29635] should_fail.cold+0x5/0xa > [ 1341.383651][T29635] ? skcipher_walk_next+0x6e2/0x1680 > [ 1341.383673][T29635] should_failslab+0x5/0x10 > [ 1341.383691][T29635] __kmalloc+0x72/0x330 > [ 1341.383720][T29635] skcipher_walk_next+0x6e2/0x1680 > [ 1341.383744][T29635] ? kfree+0xe5/0x7f0 > [ 1341.383776][T29635] skcipher_walk_first+0xf8/0x3c0 > [ 1341.383805][T29635] skcipher_walk_virt+0x523/0x760 > [ 1341.445438][T29635] xts_crypt+0x137/0x7f0 > [ 1341.449689][T29635] ? aesni_encrypt+0x80/0x80 There's one suspect-looking site in xts_crypt(): > kernel_fpu_begin(); > > /* calculate first value of T */ > aesni_enc(aes_ctx(ctx->raw_tweak_ctx), walk.iv, walk.iv); > > while (walk.nbytes > 0) { > int nbytes = walk.nbytes; > > ... > > err = skcipher_walk_done(&walk, walk.nbytes - nbytes); > > kernel_fpu_end(); > > if (walk.nbytes > 0) > kernel_fpu_begin(); > } I wonder if a slab allocation failure could leave us with walk.nbytes==0.