Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Jun 2021 16:52:21 +0200
From:   Mian Yousaf Kaukab <ykaukab@suse.de>
To:     Bruno Thomsen <bruno.thomsen@gmail.com>
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-rtc@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>, biwen.li@nxp.com,
        Bruno Thomsen <bth@kamstrup.com>
Subject: Re: [PATCH v5] rtc: pcf2127: handle timestamp interrupts
Message-ID: <20210629145221.GF81946@suse.de>
References: <20210624152241.4476-1-ykaukab@suse.de>
 <CAH+2xPBSozyY8np=KSZrDn6nwf0__J1yRtkY_O0-SsBMLxb74g@mail.gmail.com>
 <CAH+2xPA+0pej3WrUmyDnCyrWy1TjN3fHrk+L4GW+JAwyEbF5XA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAH+2xPA+0pej3WrUmyDnCyrWy1TjN3fHrk+L4GW+JAwyEbF5XA@mail.gmail.com>
Precedence: bulk

On Mon, Jun 28, 2021 at 11:42:03AM +0200, Bruno Thomsen wrote:
> Hi again,
> 
> Forgot another important comment. After you moved code to
> pcf2127_rtc_ts_read() it seems to lookup pcf2127 struct wrong.
> 
> struct pcf2127 *pcf2127 = dev_get_drvdata(dev->parent);
Good catch! I will fix it by calling pcf2127_rtc_ts_read(dev->parent).
dev_get_drvdata(dev) is correct from the irq path.
> 
> /Bruno
> 
BR,
Yousaf