Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4505748pxv; Tue, 29 Jun 2021 08:32:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/hOIH06tGu0bSxYGuVxYueSfcQ3k7PwM7/Rfd4FuGxC4R4sxFzTJiVoJbYZjpSc+hUmcw X-Received: by 2002:a92:c7cf:: with SMTP id g15mr2788892ilk.23.1624980765159; Tue, 29 Jun 2021 08:32:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624980765; cv=none; d=google.com; s=arc-20160816; b=ERSako1wX5L5z2pQgk5PAJ1ELDfDbXghfDk1e3y++Rh9dDsGmYDxzExbfQEBuaZcp6 uPwxnN3C9y+ICo8htqK/ewBvPpEWTOkWQSqEVgDPwaDmMjaWQLb8FsJ1lYsfPqjRGOon QOW+EeN8crVRBSOitWRrfvFBdYxfrerit+08WPGR7bIl+zXCFZXoLvMsBHGXO2Q4uuxR XXIkT5Cl2YwjseNNcck/z70BKlhUVzJish/JNEJrNQJkayA5MLYPq6VDysG2GTUnDpLA vcM+FQ0vphfqu2RlZJTM+jXBG4/CsMrDVJc9fkQ48C2I47UUwKM6BEnKF3MSYxhIOksy A5QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Bdy57BG4UHg3zoWEBm83afaWYyEJP4JrPq4b5ijfZcs=; b=rMGmXy93BkaXfyrswhdj53I0uUwH5lWQeLczSOhSQuO27pftcaPq/wcpVN9DW2iIw1 xXH4Hy8mMZUWQ+ueKEYwuYk71LMwbTeKs8g5Zhhw0WH8RMCFAztjOr1gpkv+ebzjSMAx GNWLJkVtmum2qn9EWkGlcXhQFQVAvJ6Ih54dB2akUyZlUAcKt777fSSxC6okz9TGIYvT 3v9k1TtRdBojV68rZohZSiZBuOt+5HDspJ7U5O1OHOrBcIsxBuD4EfcRbRhsMLPQfoNB wp2nz0gIyxoktP+tpDXqbg0/HG8fDZ+ZnsWxhJBHLFcJnQIsLTtVTCH6jD/R9/3yeQgA UYmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gJ3vk2e9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si21672410ilu.56.2021.06.29.08.32.31; Tue, 29 Jun 2021 08:32:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gJ3vk2e9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235000AbhF2Pc4 (ORCPT + 99 others); Tue, 29 Jun 2021 11:32:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57208 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235011AbhF2Pct (ORCPT ); Tue, 29 Jun 2021 11:32:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624980621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bdy57BG4UHg3zoWEBm83afaWYyEJP4JrPq4b5ijfZcs=; b=gJ3vk2e96pEUMNPxLTNuU1X5Tq9zlZAYZ+H3LvDRbCCGbZaE067mkeHdi8MZI555d5gBDx L1h6NJ215tZwHIF0s6fH4IpoNEFS7KXOCLqnMn+BfEHS4GIfsNpcvZmSBstVfIRgVoWjLe y6HEVQlQ08JwOFjv6PNTwtMyXg1hOsE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-37qbf2LDNSy1dbgOq_hOhg-1; Tue, 29 Jun 2021 11:30:19 -0400 X-MC-Unique: 37qbf2LDNSy1dbgOq_hOhg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CDE1B1084F55; Tue, 29 Jun 2021 15:30:13 +0000 (UTC) Received: from virtlab719.virt.lab.eng.bos.redhat.com (virtlab719.virt.lab.eng.bos.redhat.com [10.19.153.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38BB569CB6; Tue, 29 Jun 2021 15:30:10 +0000 (UTC) From: Nitesh Narayan Lal To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-pci@vger.kernel.org, tglx@linutronix.de, jesse.brandeburg@intel.com, robin.murphy@arm.com, mtosatti@redhat.com, mingo@kernel.org, jbrandeb@kernel.org, frederic@kernel.org, juri.lelli@redhat.com, abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org, peterz@infradead.org, davem@davemloft.net, akpm@linux-foundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, maz@kernel.org, nhorman@tuxdriver.com, pjwaskiewicz@gmail.com, sassmann@redhat.com, thenzl@redhat.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jkc@redhat.com, faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com, borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com, govind@gmx.com, jassisinghbrar@gmail.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, nilal@redhat.com, tatyana.e.nikolova@intel.com, mustafa.ismail@intel.com, ahs3@redhat.com, leonro@nvidia.com Subject: [PATCH v2 09/14] ixgbe: Use irq_update_affinity_hint Date: Tue, 29 Jun 2021 11:27:41 -0400 Message-Id: <20210629152746.2953364-10-nitesh@redhat.com> In-Reply-To: <20210629152746.2953364-1-nitesh@redhat.com> References: <20210629152746.2953364-1-nitesh@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 2ac5b82676f3..be8e4af6c283 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -3243,8 +3243,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter) /* If Flow Director is enabled, set interrupt affinity */ if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE) { /* assign the mask for this irq */ - irq_set_affinity_hint(entry->vector, - &q_vector->affinity_mask); + irq_update_affinity_hint(entry->vector, + &q_vector->affinity_mask); } } @@ -3260,8 +3260,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter) free_queue_irqs: while (vector) { vector--; - irq_set_affinity_hint(adapter->msix_entries[vector].vector, - NULL); + irq_update_affinity_hint(adapter->msix_entries[vector].vector, + NULL); free_irq(adapter->msix_entries[vector].vector, adapter->q_vector[vector]); } @@ -3394,7 +3394,7 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter) continue; /* clear the affinity_mask in the IRQ descriptor */ - irq_set_affinity_hint(entry->vector, NULL); + irq_update_affinity_hint(entry->vector, NULL); free_irq(entry->vector, q_vector); } -- 2.27.0