Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4513177pxv; Tue, 29 Jun 2021 08:43:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUk1jwPp1GSDsUrH+SU3l+f2BOsZ5n6pCkdC8HKBuA5YETWREWJ62wll9uySd9+HNRDiDt X-Received: by 2002:aa7:d413:: with SMTP id z19mr41691783edq.37.1624981394376; Tue, 29 Jun 2021 08:43:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624981394; cv=none; d=google.com; s=arc-20160816; b=K1cDLst8poqUQJ9anPtF1DdQH5TwfzdRvoGAmuQx3NHt/vxT2CwVHxVWRswGZTDfJA Qdc/8oqEh6101ddQ2L+P/FFp1O6GQzAA4cybxYNSKBJkCTHsICtYdIbk82u+SLEhDm4N sLHB3JqPpSB2ifIWhWqNALzk0Ulzn7zH/9bmBRpyploTersgUvwJDJYzur03cHdwZ9PM qyWhNqRz3JcqX+VAibQtbb9R5P34RdyuSNoTOAy5MJgn4zcHG+GPMbZsuHcXmAcu4dIp KMwrh/fsL+KDLLAiboeXZ18NFTy5nbvaOFHMAk1twVJDEYnnjYat/KpX5bDuQLwlbIIq vu3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=JE7Kuq7Nb9jg85fmCIleEaH75sWYHkI/j6GaTCzguyQ=; b=m1c7njCIkmGC9E64uPOXEP+qtYS391a/Lw8Dl23iHZ2OZowFq8ayDyo6Q4SHgEUPf6 zzAB7AGuE+tOoVyJQN88HYbvtoK+aVTBgLWWlqxLB2fSvYAr9Sh81H5LTaB8cz4UNAiA 1L+XLf8fzq4aGpRmMlapF2Fkb3LwiDKxg+dBR8I6OSQtnxTv7x3xslWICxTTE1izeTP5 aqPJgIL8xU1UqEQDB5x4qnIGUgeSy5YGuHYqvnnsIymro4Fp+5rcVix9jn79BZOezug9 3fv7zdWpVVk+Rc3iYuLlbzSKaRx9QFxUBNugs97eYVKzvkdoPEc04qq9L9b8VnhI7iiD K8zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eXel4XjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gx15si17392855ejc.466.2021.06.29.08.42.51; Tue, 29 Jun 2021 08:43:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eXel4XjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235023AbhF2Pcy (ORCPT + 99 others); Tue, 29 Jun 2021 11:32:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25188 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235000AbhF2Pco (ORCPT ); Tue, 29 Jun 2021 11:32:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624980617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JE7Kuq7Nb9jg85fmCIleEaH75sWYHkI/j6GaTCzguyQ=; b=eXel4XjHTeKmZH8JajxSYj9OfIu/cFV3MKzCD7/1BcvMggc338D2R0r08sKPy5ZCUfdTeX 1j+4eZG0Hct9Ym7UNrGcgIp7P6ZGnXomdkcLivz1TXwzBM5g98Gwmq7aBzDW8lCRUxJ3vq yLI/StVAA2NLyP5gpwi2U8+8Oy9+glE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-p5gLeRczNFGoM_uKUMw1Ng-1; Tue, 29 Jun 2021 11:30:15 -0400 X-MC-Unique: p5gLeRczNFGoM_uKUMw1Ng-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F2641084F54; Tue, 29 Jun 2021 15:30:10 +0000 (UTC) Received: from virtlab719.virt.lab.eng.bos.redhat.com (virtlab719.virt.lab.eng.bos.redhat.com [10.19.153.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65444604CC; Tue, 29 Jun 2021 15:30:01 +0000 (UTC) From: Nitesh Narayan Lal To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-pci@vger.kernel.org, tglx@linutronix.de, jesse.brandeburg@intel.com, robin.murphy@arm.com, mtosatti@redhat.com, mingo@kernel.org, jbrandeb@kernel.org, frederic@kernel.org, juri.lelli@redhat.com, abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org, peterz@infradead.org, davem@davemloft.net, akpm@linux-foundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, maz@kernel.org, nhorman@tuxdriver.com, pjwaskiewicz@gmail.com, sassmann@redhat.com, thenzl@redhat.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jkc@redhat.com, faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com, borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com, govind@gmx.com, jassisinghbrar@gmail.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, nilal@redhat.com, tatyana.e.nikolova@intel.com, mustafa.ismail@intel.com, ahs3@redhat.com, leonro@nvidia.com Subject: [PATCH v2 08/14] be2net: Use irq_update_affinity_hint Date: Tue, 29 Jun 2021 11:27:40 -0400 Message-Id: <20210629152746.2953364-9-nitesh@redhat.com> In-Reply-To: <20210629152746.2953364-1-nitesh@redhat.com> References: <20210629152746.2953364-1-nitesh@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal --- drivers/net/ethernet/emulex/benet/be_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 7968568bbe21..72fef9d882e2 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -3491,7 +3491,7 @@ static int be_msix_register(struct be_adapter *adapter) if (status) goto err_msix; - irq_set_affinity_hint(vec, eqo->affinity_mask); + irq_update_affinity_hint(vec, eqo->affinity_mask); } return 0; @@ -3552,7 +3552,7 @@ static void be_irq_unregister(struct be_adapter *adapter) /* MSIx */ for_all_evt_queues(adapter, eqo, i) { vec = be_msix_vec_get(adapter, eqo); - irq_set_affinity_hint(vec, NULL); + irq_update_affinity_hint(vec, NULL); free_irq(vec, eqo); } -- 2.27.0