Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210629121848.6527-1-linux.amoon@gmail.com>
In-Reply-To: <20210629121848.6527-1-linux.amoon@gmail.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Tue, 29 Jun 2021 18:04:44 +0200
Message-ID: <CAFBinCB8Gnj++2YKD3hf-8zyLfj5KyE3twv58XKV9L7-2jRmJg@mail.gmail.com>
Subject: Re: [PATCHv1] arm64: amlogic: Fix the pwm regulator supply property
 in node
To:     Anand Moon <linux.amoon@gmail.com>
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Neil Armstrong <narmstrong@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Anand,

thanks for investigating this and for sending a fix!

On Tue, Jun 29, 2021 at 2:19 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> On enable CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
see my comment on the previous patch

> Changes help link VDDCPU_A and VDDCPU_B pwm regulator to 12V regulator
> supply instead of dummy regulator.
>
> [    4.147196] VDDCPU_A: will resolve supply early: pwm
> [    4.147216] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply from device tree
> [    4.147227] pwm-regulator regulator-vddcpu-a: Looking up pwm-supply property in node /regulator-vddcpu-a failed
> [    4.147258] VDDCPU_A: supplied by regulator-dummy
> [    4.147288] regulator-dummy: could not add device link regulator.12: -ENOENT
> [    4.147353] VDDCPU_A: 721 <--> 1022 mV at 871 mV, enabled
> [    4.152014] VDDCPU_B: will resolve supply early: pwm
> [    4.152035] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply from device tree
> [    4.152047] pwm-regulator regulator-vddcpu-b: Looking up pwm-supply property in node /regulator-vddcpu-b failed
> [    4.152079] VDDCPU_B: supplied by regulator-dummy
> [    4.152108] regulator-dummy: could not add device link regulator.13: -ENOENT
>
> Fixes: d14734a04a8a ("arm64: dts: meson-g12b-odroid-n2: enable DVFS")
I suggest changing the subject to include "dts", for example:
arm64: dts: amlogic: ...
(note: lower-case arm64 is correct here - even though it's different
from the 32-bit ARM prefix)

$ grep -lR pwm-regulator arch/arm64/boot/dts/amlogic/
arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi
arch/arm64/boot/dts/amlogic/meson-sm1-khadas-vim3l.dts
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
Are you planning to also send patches for the other board .dts as well?


Best regards,
Martin