Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Kees Cook <keescook@chromium.org>,
        Heiko Carstens <hca@linux.ibm.com>
Cc:     Jan Hoeppner <hoeppner@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-hardening@vger.kernel.org
References: <20210616201917.1246079-1-keescook@chromium.org>
From:   Stefan Haberland <sth@linux.ibm.com>
Subject: Re: [PATCH] s390/dasd: Avoid field over-reading memcpy()
Message-ID: <bea0aa5b-a150-e5af-c22a-367f475c172f@linux.ibm.com>
Date:   Tue, 29 Jun 2021 17:51:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210616201917.1246079-1-keescook@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Precedence: bulk

Am 16.06.21 um 22:19 schrieb Kees Cook:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field array bounds checking for memcpy(), memmove(), and memset(),
> avoid intentionally reading across neighboring array fields.
>
> Add a wrapping structure to serve as the memcpy() source, so the compil=
er
> can do appropriate bounds checking, avoiding this future warning:
>
> In function '__fortify_memcpy',
>     inlined from 'create_uid' at drivers/s390/block/dasd_eckd.c:749:2:
> ./include/linux/fortify-string.h:246:4: error: call to '__read_overflow=
2_field' declared with attribute error: detected read beyond size of fiel=
d (2nd parameter)
>
> Signed-off-by: Kees Cook <keescook@chromium.org

Thanks,

applied.