Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qVB0RpgGwH1F6dz2tl5iAwN+ANVx04yKK5k/AZKa9EocSRYmfKm9oKlYKFnSYVZnO60yQwtanR
 9Q15S52M3LHM3H1+XtlbITRhK8WBwbvdD/wLvzzh5yjA+93in1zSOVmiu9b/M3o7KIeEbZ6fe+
 3eomNmG1wl62cNr7eSiDC2cyOyjs10I0nV/q8Jc2jonMOQTgbA4UdL852shIsUcHsLkvcofm1L
 KQWSyeOkWvzif9hHcbKQgbrdBM0N+ATBe79WS3TuXcchkndmkwQMdw0Fh4VUv7tPoWTU/37VOt
 X1c=
From:   Dan Sneddon <dan.sneddon@microchip.com>
To:     Mark Brown <broonie@kernel.org>,
        Dan Sneddon <dan.sneddon@microchip.com>,
        <linux-spi@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
CC:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: [PATCH] spi: atmel: Fix CS and initialization bug
Date:   Tue, 29 Jun 2021 09:29:14 -0700
Message-ID: <20210629162914.23286-1-dan.sneddon@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Commit 5fa5e6dec762 ("spi: atmel: Switch to transfer_one transfer
method") switched to using transfer_one and set_cs.  However, the driver
expects to call cs_activate even with a gpio controlled chip select.  If
cs_activate isn't called the settings programmed with the call to
spi_setup won't get programmed into the hardware.  This patch makes
sure the cs_activate call is made even with a gpio controlled chip
select.

Fixes: 5fa5e6dec762 ("spi: atmel: Switch to transfer_one transfer method")

Signed-off-by: Dan Sneddon <dan.sneddon@microchip.com>
---
 drivers/spi/spi-atmel.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 2ef74885ffa2..84d902c469cf 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -352,8 +352,6 @@ static void cs_activate(struct atmel_spi *as, struct spi_device *spi)
 		}
 
 		mr = spi_readl(as, MR);
-		if (spi->cs_gpiod)
-			gpiod_set_value(spi->cs_gpiod, 1);
 	} else {
 		u32 cpol = (spi->mode & SPI_CPOL) ? SPI_BIT(CPOL) : 0;
 		int i;
@@ -369,8 +367,6 @@ static void cs_activate(struct atmel_spi *as, struct spi_device *spi)
 
 		mr = spi_readl(as, MR);
 		mr = SPI_BFINS(PCS, ~(1 << chip_select), mr);
-		if (spi->cs_gpiod)
-			gpiod_set_value(spi->cs_gpiod, 1);
 		spi_writel(as, MR, mr);
 	}
 
@@ -400,8 +396,6 @@ static void cs_deactivate(struct atmel_spi *as, struct spi_device *spi)
 
 	if (!spi->cs_gpiod)
 		spi_writel(as, CR, SPI_BIT(LASTXFER));
-	else
-		gpiod_set_value(spi->cs_gpiod, 0);
 }
 
 static void atmel_spi_lock(struct atmel_spi *as) __acquires(&as->lock)
@@ -1271,9 +1265,9 @@ static void atmel_spi_set_cs(struct spi_device *spi, bool enable)
 	 * since we already have routines for activate/deactivate translate
 	 * high/low to active/inactive
 	 */
-	enable = (!!(spi->mode & SPI_CS_HIGH) == enable);
 
-	if (enable) {
+	if ((enable && (spi->mode & SPI_CS_HIGH))
+			|| (!enable && !(spi->mode & SPI_CS_HIGH))) {
 		cs_activate(as, spi);
 	} else {
 		cs_deactivate(as, spi);
@@ -1483,7 +1477,8 @@ static int atmel_spi_probe(struct platform_device *pdev)
 	master->bus_num = pdev->id;
 	master->num_chipselect = 4;
 	master->setup = atmel_spi_setup;
-	master->flags = (SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX);
+	master->flags = (SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX |
+			SPI_MASTER_GPIO_SS);
 	master->transfer_one = atmel_spi_one_transfer;
 	master->set_cs = atmel_spi_set_cs;
 	master->cleanup = atmel_spi_cleanup;
-- 
2.17.1