Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 2/2] MIPS: Loongson64: Add pm block node for
 Loongson-2K1000
To:     Qing Zhang <zhangqing@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Huacai Chen <chenhuacai@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210629011913.18611-1-zhangqing@loongson.cn>
 <20210629011913.18611-2-zhangqing@loongson.cn>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Message-ID: <7caf171a-7d7d-4f2a-a065-58fadace690d@gmail.com>
Date:   Tue, 29 Jun 2021 20:20:06 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210629011913.18611-2-zhangqing@loongson.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/29/21 4:19 AM, Qing Zhang wrote:

> The module is now supported, enable it.
> 
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
> 
> v4-v5:
> add missing spaces
> 
>  arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> index 569e814def83..38bf14f00694 100644
> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> @@ -101,6 +101,16 @@ uart0: serial@1fe00000 {
>  			no-loopback-test;
>  		};
>  
> +		pm: power-controller {
> +			device_type = "power management";
> +			compatible = "loongson, reset-controller";
                                               ^
   When I said te space aren't allowed, I meant this place. :-)

> +
> +			reg = <0 0x1fe0700c 0 0x8>,
> +			      <0 0x1fe07014 0 0x8>,
> +			      <0 0x1fe07030 0 0x8>;

   TY! :-)

[...]

MBR, Sergei