Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4615778pxv; Tue, 29 Jun 2021 11:09:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+CcNT/ic5eHIkd83QiXYEcABsFg/1rDOjnwCfcpZRPpGkNs9xzXWhlKFBY+JZ3ifcCfGv X-Received: by 2002:a17:906:dbd5:: with SMTP id yc21mr31709480ejb.223.1624990179063; Tue, 29 Jun 2021 11:09:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624990179; cv=none; d=google.com; s=arc-20160816; b=SEofvBJ34XUUv5pGd+syQt/viCdfT0C1YaN1jhN8syWizv+kgFLs7j+XiljaHiTvbQ 2Cn5UrqhPCFKk1QIk/RBtOCDCUL5XlYwxn3zxpU2iHMKLw9vufFWagrwhpSyizBSKS9v wgajGqXQiYrXYTvyzXyVVZzojudeTimLKQsOK9sM9mt+o+P3/+KM6dsFHCt9L6jCixd3 4+8OwR9t1JMHTY+Ns0/5S9a6Gcn0fa7fYYLMe143g51xpnryiv0vFvGB1cFXJK/IMJbF D8SXJL0F8h6ORAsggO6g3cUsYqhMflHkAmHMvLsUXzoom/kJubcBDMl/noMjQAeGpinq n78w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=mEmbsX/nu/NJ1yHIBHbUXLhugKATA13h8CY3L/8A+y0=; b=IQoHq/btL4ZGdgXBR8A5Zn/qUHNTK04caAFQtK6hlryiz3rEMm756NamkbtDqXMcL+ n8mu8btRmq2CKqtnx5PxWI+o506HxeCS02PCPxMf1IzNr2AqwvpY2XGJcYDLqKmfBCwl 0fhaaCBtNVDTQsyZ+rKH1bIlq8Q4IJCcdzRuJYRC702w3qYBwgRyEYH1zLnn7x5+RlMV YxS0ZPr9RjPG/UVkElAkIkHPT2fFKE0VBrBl6NRVElfVBUnrbp8TovMGPFehbsAJ/nDa cVGZfj+DMFSJY3ClHsPEtdvGFSF5VpkukW4bDTwedhZ7c6fh3RSKzyHwE7XOxgBemTaF HNWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb10si15586294ejc.321.2021.06.29.11.09.15; Tue, 29 Jun 2021 11:09:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234427AbhF2SAe (ORCPT + 99 others); Tue, 29 Jun 2021 14:00:34 -0400 Received: from mga04.intel.com ([192.55.52.120]:52983 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231856AbhF2SAd (ORCPT ); Tue, 29 Jun 2021 14:00:33 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10030"; a="206379724" X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="206379724" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 10:58:06 -0700 X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="643806408" Received: from bzhang2-mobl1.amr.corp.intel.com (HELO [10.255.231.86]) ([10.255.231.86]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 10:58:05 -0700 Subject: Re: [PATCH RFC 2/7] kvm: x86: Introduce XFD MSRs as passthrough to guest To: "Liu, Jing2" , Sean Christopherson Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jing2.liu@intel.com References: <20210207154256.52850-1-jing2.liu@linux.intel.com> <20210207154256.52850-3-jing2.liu@linux.intel.com> <3c63438b-2a42-0b81-f002-b937095570e1@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <895e41d7-b64c-e398-c4e2-6309c747068d@intel.com> Date: Tue, 29 Jun 2021 10:58:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <3c63438b-2a42-0b81-f002-b937095570e1@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/27/21 7:00 PM, Liu, Jing2 wrote: > On 6/24/2021 1:50 AM, Dave Hansen wrote: >> On 5/24/21 2:43 PM, Sean Christopherson wrote: >>> On Sun, Feb 07, 2021, Jing Liu wrote: >>>> Passthrough both MSRs to let guest access and write without vmexit. >>> Why? Except for read-only MSRs, e.g. MSR_CORE_C1_RES, >>> passthrough MSRs are costly to support because KVM must context >>> switch the MSR (which, by the by, is completely missing from the >>> patch). >>> >>> In other words, if these MSRs are full RW passthrough, guests >>> with XFD enabled will need to load the guest value on entry, save >>> the guest value on exit, and load the host value on exit. That's >>> in the neighborhood of a 40% increase in latency for a single >>> VM-Enter/VM-Exit roundtrip (~1500 cycles => >>>> 2000 cycles). >> I'm not taking a position as to whether these _should_ be passthrough or >> not.  But, if they are, I don't think you strictly need to do the >> RDMSR/WRMSR at VM-Exit time. > Hi Dave, > > Thanks for reviewing the patches. > > When vmexit, clearing XFD (because KVM thinks guest has requested AMX) can > be deferred to the time when host does XSAVES, but this means need a new > flag in common "fpu" structure or a common macro per thread which works > only dedicated for KVM case, and check the flag in 1) switch_fpu_prepare() > 2) kernel_fpu_begin() . This is the concern to me. Why is this a concern? You're worried about finding a single bit worth of space somewhere?