Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 29 Jun 2021 17:47:33 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Dan Sneddon <dan.sneddon@microchip.com>
Cc:     linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: Re: [PATCH] spi: atmel: Fix CS and initialization bug
Message-ID: <20210629164733.GE4613@sirena.org.uk>
References: <20210629162914.23286-1-dan.sneddon@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="BQPnanjtCNWHyqYD"
Content-Disposition: inline
In-Reply-To: <20210629162914.23286-1-dan.sneddon@microchip.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--BQPnanjtCNWHyqYD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 29, 2021 at 09:29:14AM -0700, Dan Sneddon wrote:

> spi_setup won't get programmed into the hardware.  This patch makes
> sure the cs_activate call is made even with a gpio controlled chip
> select.

In what way does it do that?  I can't tell what the patch is supposed to
do.

> -	enable =3D (!!(spi->mode & SPI_CS_HIGH) =3D=3D enable);
> =20
> -	if (enable) {
> +	if ((enable && (spi->mode & SPI_CS_HIGH))
> +			|| (!enable && !(spi->mode & SPI_CS_HIGH))) {

This looks especially suspicious.

--BQPnanjtCNWHyqYD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDbTqQACgkQJNaLcl1U
h9BN5gf+Pm6DMsgO/YsJGrz7jXmNW/56VqpC35uRtHR82xH4vfY1/JRrIgY7+4Qz
EjZcYWpAqaEWybRZIvsB2BAlcqGe1ACpCaIfITPpLOv8+tNyZyke4ATyAMtkWDXc
q7o2sG+2HqriF1VUAIAoIHvtAEifVOmO9s5tuB+lvaZaws1MisfWifEKKpAvOqpi
TdVZlm3+46aRRBLOWCYsKDa8mABe/Z8LPNuIGfZYisVtuqF8uXfowgZ+qpTkhKqA
KIlovuKsf+jgNnlN7zowJrYdkcG3l6RR/aw2l/J83ud4ZSJeJn4/s+QYfEJZi3M3
UK5yQuVk/JlscHVR4LdWX+Yh8MLB9A==
=G/4+
-----END PGP SIGNATURE-----

--BQPnanjtCNWHyqYD--