Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210629121459.6341-1-linux.amoon@gmail.com> <CAFBinCA=COnsN4Cp-z0HAPgs4kqPdiKtkZkr_LDkGz68s7B7hA@mail.gmail.com>
In-Reply-To: <CAFBinCA=COnsN4Cp-z0HAPgs4kqPdiKtkZkr_LDkGz68s7B7hA@mail.gmail.com>
From:   Anand Moon <linux.amoon@gmail.com>
Date:   Wed, 30 Jun 2021 00:30:14 +0530
Message-ID: <CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com>
Subject: Re: [PATCHv1] arm: dts: meson: Fix the pwm regulator supply property
 in node
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-amlogic@lists.infradead.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        devicetree <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Martin,

Thanks for your review comments.

On Tue, 29 Jun 2021 at 21:31, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Anand,
>
> On Tue, Jun 29, 2021 at 2:15 PM Anand Moon <linux.amoon@gmail.com> wrote:
> >
> > On enable CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> I (as non-native english speaker) suggest rewording this to:
> After enabling CONFIG_REGULATOR_DEBUG=y we observe below debug logs.
>
Opps: I will fix this in the next version.

> > Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> > instead of dummy regulator.
> >
> > [    7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> > [    7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> > [    7.117184] VCCK: supplied by regulator-dummy
> > [    7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> > [    7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> > [    7.118498] VDDEE: will resolve supply early: pwm
> > [    7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> > [    7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> > [    7.118553] VDDEE: supplied by regulator-dummy
> > [    7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
> excellent catch, thanks for sending a patch!
>
> > Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
> > Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
> >
> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Thanks

> For the subject:
> - patches for 32-bit ARM should start with upper-case ARM
> - personally I also include the board name so the git history is easier to read
>
> My suggestion for the subject line is:
> ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
>
Ok I will try to incorporate your suggestion in the next version.

> Are you also planning to send patches for the following 32-bit SoC boards?
> - arch/arm/boot/dts/meson8b-mxq.dts
> - arch/arm/boot/dts/meson8b-ec100.dts
>
Ok I will try to send all updates in the next series.

>
> Best regards,
> Martin