Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kees Cook <keescook@chromium.org>
To:     Tony Luck <tony.luck@intel.com>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pstore/blk: Use "%lu" to format unsigned long
Date:   Tue, 29 Jun 2021 14:12:05 -0700
Message-Id: <162500112137.438178.14586324457676666976.b4-ty@chromium.org>
In-Reply-To: <20210629103700.1935012-1-geert@linux-m68k.org>
References: <20210629103700.1935012-1-geert@linux-m68k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 29 Jun 2021 12:37:00 +0200, Geert Uytterhoeven wrote:
> On 32-bit:
> 
>     fs/pstore/blk.c: In function ‘__best_effort_init’:
>     include/linux/kern_levels.h:5:18: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
> 	5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
> 	  |                  ^~~~~~
>     include/linux/kern_levels.h:14:19: note: in expansion of macro ‘KERN_SOH’
>        14 | #define KERN_INFO KERN_SOH "6" /* informational */
> 	  |                   ^~~~~~~~
>     include/linux/printk.h:373:9: note: in expansion of macro ‘KERN_INFO’
>       373 |  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> 	  |         ^~~~~~~~~
>     fs/pstore/blk.c:314:3: note: in expansion of macro ‘pr_info’
>       314 |   pr_info("attached %s (%zu) (no dedicated panic_write!)\n",
> 	  |   ^~~~~~~

Applied to for-next/pstore, thanks!

[1/1] pstore/blk: Use "%lu" to format unsigned long
      https://git.kernel.org/kees/c/c5d4fb2539ca

-- 
Kees Cook