Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4793722pxv; Tue, 29 Jun 2021 16:11:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwR7QfW8Ov0prPjrr3Yx/2/g1cLyFXzdz2TCI34dqAuoWS/5pyD6l6y+xwmdgLQHdCcOayo X-Received: by 2002:a05:6e02:1b85:: with SMTP id h5mr15976238ili.99.1625008306775; Tue, 29 Jun 2021 16:11:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1625008306; cv=pass; d=google.com; s=arc-20160816; b=NGnaeQvPP8gUu0fhX5AX9LTRBq/kcVRZlyv4dUsDT8U1uFM4DJCAEloZZzTQnqWbgP ifUuwFFOXRJ7yZRZBG53yEzY3Itoa4nXGCzrlCjVgjUltQ6HDojFFp+Y2b6zG3T1cAkX j6uB2zjpH4bl3vreStDcTBSJu0CDz4LbhEO5K5NhavwlXFRkTb0EdxKIlcxf4oNQR+FI 0YBKyUdPWBVpx6djEkZNwqP+zPtfCC6E1iJNUn3rbkSGSbCkTh+yK/In5D8cqL/WtbNM dUHfiTaDFcLGbrBmXbV+P4v/i9p1A/xxIBNAvGZaW4JFeZrRRBMAxm71VvUmO7QYvCSV LBIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:content-disposition :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zjno58Xbn8BDQL8wko4Rnl3kabEv9FukfUU3m/hXLE4=; b=RLWtSUQ6dQOMhydY+xpgpW1B6s0z+5zhEojq1LLFCASKYub4I2gcdMO9X8vu8aQHH9 KmYEolTltkGcKaIpfbwJT04N0SlKcf7GB22luvhhNOt62e6gZwsk6STRz3OTfomKalMX 4oHNrzPaIXYk9YH+w2GrZI/WpOEO5SpQyXHx7b0/ntXgehLeCO8gS3KHN3rgGf0xyjQi XcMRonPI1Yuy0eLqsJLuf9MOyo7WwvR2qafKrBnjX+hFxLZLQq/1srFuEbBFY4Txf4AH nO5CRzrf5ltJMvw5aif5QX+ecyos/RM4HXFL7aKQmWhwqDesvmgYJnn/zjZ/Qt04DZKe IMig== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=kXqEj85H; arc=pass (i=1 spf=pass spfdomain=nvidia.com dkim=pass dkdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h4si8811329ioe.0.2021.06.29.16.11.35; Tue, 29 Jun 2021 16:11:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=kXqEj85H; arc=pass (i=1 spf=pass spfdomain=nvidia.com dkim=pass dkdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235465AbhF2XLD (ORCPT + 99 others); Tue, 29 Jun 2021 19:11:03 -0400 Received: from mail-sn1anam02on2089.outbound.protection.outlook.com ([40.107.96.89]:50126 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231952AbhF2XKw (ORCPT ); Tue, 29 Jun 2021 19:10:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jFqqtMIQJc/poPWFoL5PCxXIOz4oKgljSnJgrU1zK45xCoiyOJJPHjg7NMqYvmL3zHysqgxNKKJknFepYA4GKUbix9Ksso2dSHQh83vkOCns9zAkMq3Hpgricwt2kDTmzrxtl3GUA4kZ31Qs8i+eKcIT0GaS1bOqr5TdoXV1znKwm94pI+l+gte+6TBU75Ag2BWdk4PzfoDUOD9u+Yz0kcb/4RZIaIh6R+WoiVIYQN7+ozEed2TnlCE74BJEmB/pEPNx5TZAOi6wINW9TbEb3TP0WrKiMT1YMFC0/z38yEThKVbAzn0nG013ckfS2P6JUMOUt1KVxA3iwVKW+C/4mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjno58Xbn8BDQL8wko4Rnl3kabEv9FukfUU3m/hXLE4=; b=FUzTljKCxnOER2ChA1gtMtIOQ0r9T5OHaC5JYYkDq7DGCaRo9cY6wj1cewzmmkSQqY/eUu0zJk2nKDmWZsPi5UeaO84dGa2jZEvxzcUmfd5J1jsuclLvSxwtMg/af+UbvtibkVJ6WYEJkwyorPegYVYwd42RWXZoMYOyI/qXa2hZEOquE86i02kdxKn9Y8cy5LSJRBejV1xl3Snyd0OPDOkadEhkjN0Ossbww9UbpqwTQkb/Brhe3uNV/2TBpA+TSAhh6ukv7I7nONdWU+ONNaZvG1BWzujm+Mf10AH9ElDaIWwvzVkWVZdNKmnM3zdknkWYlj/Kf6ac/6+5zqavbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjno58Xbn8BDQL8wko4Rnl3kabEv9FukfUU3m/hXLE4=; b=kXqEj85HFjx2EP+sJDO94xOsy2725nCR6EdDnVY7d3SoJgZ7ftzTXdc9Zhl22j8CbPiJONVRE1Gp4RnL4pxJTKtl0AvQYvpE2L8/XLN5mIYjiWQIaly6IqB5YImNPhD2yVVvlRyn5vCyV7/q/LjSqjxaWMz2fDYYBOAF/+nQMA44bsE9FSlQHKfiZDeIn5IagnVIIQI+YgI55LtFEtalhZIdXoPjcLCXffc3sBL50YmVIBH2lT94Sl5yB57ptteCPlHh3dh5SfGXozRJi1VCgYczjaCDv6LT2gbz8g/+9UEHHX0B0MXCEenJrFb9Wqx9V4Bk74ZzHTVj5MPb6t4pig== Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) by BL1PR12MB5064.namprd12.prod.outlook.com (2603:10b6:208:30a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Tue, 29 Jun 2021 23:08:23 +0000 Received: from BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::3d51:a3b9:8611:684e]) by BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::3d51:a3b9:8611:684e%8]) with mapi id 15.20.4264.027; Tue, 29 Jun 2021 23:08:23 +0000 Date: Tue, 29 Jun 2021 20:08:23 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Leon Romanovsky , Dennis Dalessandro , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Maor Gottlieb , Mike Marciniszyn , Yishai Hadas , Zhu Yanjun Subject: Re: [PATCH rdma-next v1 0/2] SG fix together with update to RDMA umem Message-ID: <20210629230823.GC278274@nvidia.com> References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Originating-IP: [47.55.113.94] X-ClientProxiedBy: BL1PR13CA0019.namprd13.prod.outlook.com (2603:10b6:208:256::24) To BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mlx.ziepe.ca (47.55.113.94) by BL1PR13CA0019.namprd13.prod.outlook.com (2603:10b6:208:256::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.14 via Frontend Transport; Tue, 29 Jun 2021 23:08:23 +0000 Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lyMq7-001ARZ-2t; Tue, 29 Jun 2021 20:08:23 -0300 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bbc809fb-4839-4cb7-2b73-08d93b52cb86 X-MS-TrafficTypeDiagnostic: BL1PR12MB5064: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YL1Awq3jNa/r6giE5l0EUMihiD0fpkM1bVxzl17tfccPQKWyZ+KFJujq/ED/luBMscMBuVriZ/hlTA4Fo2iEkjqoQfACgLX/M3KsGUAyLoh4XMs9evtYYZVtTr19weOZiahptJ+ShavqGw5LlsjGsMbT3O5Xzl/MVc8XyB6GmDqOqceR/VHIHvZx4Lmyc+mmFv4Jad3PApNcL3aa5PVmhcKYS8uRzXbJm1OaHqSJGZenAvAU7QFtFnJ2M52wH4zY7za9snO9JG/xfw5NB1hdRthh7bNkI7xNVnefX6SV2tPjxK3PK6VUWBy5dkwwpPQNj9wc1bwKDNUG4PXKwgvCzcC7E8CoQETq8fBWx5wuePBI/CTwc+qrRzjwncGtGLJjzoxiEj2UKdUbxqvEbN4MGQ1FuD4XUtCdBdV8IbIjJAyCLQhms3N46gfC9FVGYzHMRjYoIsS+FiZ/p8hwsbA/A2FCAJgVwqLa9VNj3af+MsmMRloMbOajwdZv2M8FIz3Uo0lMiM+epkp4XB7vTaf4DxlNxKTbUxRKI6RGYGSUpwVpcpT0sgfQY6nZ5VXMMPhegkjqgcwTWqeCi0YKK16vtWQtOpFUQcamWTmxwlCsxAzx04iYVDfsxnRviUIzcMflgybNmgsmYRRoiUDoFORRtjIq0vdq9aGqR2kmXqPYAjbAZxzH+n0vItgRrv1VAAqe4VEkGcLLXDNLZ1JyZt5E124pn3xg7mRojq4Qyv49EYF9U2cs1HukUkGVbXrZReU8QaqjLQClgBXEz84PrcfwLhHO3POCAcVB6R61Q7KT1+L/ELG3r735sWBVyVx0MKai X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(15650500001)(4326008)(8936002)(38100700002)(966005)(316002)(8676002)(9786002)(9746002)(26005)(478600001)(6916009)(54906003)(186003)(2906002)(36756003)(2616005)(4744005)(426003)(5660300002)(66946007)(86362001)(66476007)(66556008)(1076003)(83380400001)(33656002)(27376004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NyH+lrdXzo/RNhSfdcCsKVcCer81KtdY1A3+zSWnHGVWjp2NYJAcoIiDaRvK?= =?us-ascii?Q?3qfm9LeCPe6CdQ2YyQZ27v0ZSB/hhDepl0oMeOnXSpIE7Cjhw1C3hVvE7qei?= =?us-ascii?Q?Un0+pfPjPGvTehXtiWhGP/AR2Oz7nWSwhHzC4W/czfFdy/AOlnLGz03zU0ix?= =?us-ascii?Q?9gZGJOF0sWR5929/U9bi4vXTP2K3TgPibP5W6UVw3Ehyce+/knXvrW8+PVVH?= =?us-ascii?Q?wKSbo/iASjs27n8B4nVmhoPc/l1eT7VtIsxR9o8TvIRjsTuOmyDxNQRkfkz6?= =?us-ascii?Q?FBiFC5Ef0eAvI/ndsWOUr9q050wowE81Sv+t96FKo1mi4ywMv4K/xfSxx6//?= =?us-ascii?Q?tRwh0N2M6oS5EbYIcBR1YE/Giu8D4fWETjQoasViuo6L0jq7bqKpApL31QOK?= =?us-ascii?Q?2RFnmRzgjXhlwMfvvfOrqKK6nxPw5g6+wbGNYtDvvp9PvrUgid3N+6ROpVk8?= =?us-ascii?Q?2gwJkBasinXjgTrH+fAPYx0dZcLOc6W9250qDnjac8YwLBpgDs7uOQTShdt7?= =?us-ascii?Q?Ks5BsCAB4UGGgMU47tkPvFGaWxctpQNjgoPaIcbHgy5Gg0o+VXwXm8YHyBm3?= =?us-ascii?Q?COole4qWr+derFw9irCOuSBAuMntBw2m27fvpF8+hHtCzPQ0GzSrHZkwIGw8?= =?us-ascii?Q?G4sROuD64/sHsevnLY1llp3VzYbeKSx5MtcccMkk2ufAKqvuJPLHFt1wb4Bv?= =?us-ascii?Q?tLeXf8o3RAGWIj0vua26pIHSC1I0hpBwrs5YM+QUlkrJ1AjFd6iQvZoETqCi?= =?us-ascii?Q?CI5nOvHonmuDHDzvBiv5uqnYh/FbqGKs9dMsCgQJqgTAVJhk8mBSUlBvgxB0?= =?us-ascii?Q?luzI/rPQvTOvLZxTRWjTuzAEv/gVLCQDQp9FPjog8PIU8/Hgkh8DrggrP0Gq?= =?us-ascii?Q?IVEMem6GSYFDw+W+txtMTs3rJWjxD/INqWCFYlCsAnQIIFlM22HlxjN8fP4V?= =?us-ascii?Q?W0xfMKUb3bjEbUsIfeSIceFye/6CUikwkQZOFDBrsrm0AeP4VjHoaLd5Q/Py?= =?us-ascii?Q?U0JmpGhhi7nCZhy8zxMYY+0EwsEHF0yRhQnFEwWl8IWUVz/Gpmbzl27dQ5wh?= =?us-ascii?Q?FfXXhgK/xYuyilG/CQTObdcb0lkkO1+ABeClb8YCM5ESjKnBEQqf9erSLIi1?= =?us-ascii?Q?kiBYNrsz3CKmTbnP/FWlNTTWFL210pCoC++t3RZHCl9vPSqdB+/THL9RpKRr?= =?us-ascii?Q?TqnjcZSUn9m82pOGuwpghwsvGXuhVEyDRL70KtobdHFTMJnJutkzItnXyHGT?= =?us-ascii?Q?AnHTj6DZM4vU03alxhStaz+wlR/BOcdBwro0Jz8vIrRbXgFvC3YpfhVUwiM/?= =?us-ascii?Q?XDARbbpZn6/2bwaOTyYO7Pns?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbc809fb-4839-4cb7-2b73-08d93b52cb86 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 23:08:23.8596 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mHqtdUXwmbSQlLah3AKZmsBBkGwSvfVFBs4nDYdARBSDGPthYBx2umqtzsqiLSFA X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5064 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 29, 2021 at 11:40:00AM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v1: > * Fixed sg_page with a _dma_ API in the umem.c > v0: https://lore.kernel.org/lkml/cover.1624361199.git.leonro@nvidia.com > > Maor Gottlieb (2): > lib/scatterlist: Fix wrong update of orig_nents > RDMA: Use dma_map_sgtable for map umem pages Though I would have liked to see some ack, I think fixing the semantic bug here is important enough. Yell quick if there is any concern as my PR will go tomorrow. Applied to for-next. Thanks, Jason