Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4897122pxv; Tue, 29 Jun 2021 19:27:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/itylVq3IsVfPERej5fxsfu3ACyphUJB1jperIQfN6OjZiEBtjM9Ow4yZJceZ/enD/itM X-Received: by 2002:a92:6d0b:: with SMTP id i11mr24191305ilc.160.1625020072309; Tue, 29 Jun 2021 19:27:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625020072; cv=none; d=google.com; s=arc-20160816; b=M3ppDHxYfdGgDSsbVMzxPRVEJ7UeB2Uz01jnr4VT6POfdOAYqvfMe5GBuIbF4FI15A vjgB/zRHumPkRUUZL8p8rSESg5nchMS8vwkNY0WGaU6t2CCD0f1hivZEjPeZrr5u1Xh9 MHrflZ1VQmam8Mr/uXhcdKTJI7joMwU2786vUzLpWOzu7/Fysyu6H/HOv4oCAqxBprTu lo7f9TTpq8LKLkf/TV3rvfDIKYdJ7HFDb1ijTKJAqav1208nBn8I/zdJqwYIFJQRfEeq NQjuFAzV3IXlRMYzOeV5G7snM1gjEM6sCQvRRQ7u7oqzbEU02XEKtJvmLxVHDd0XAfbC AuIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=3X1XsB9jdur4oaQoDKJ7iVYQFaAYkUhO9XyXxv90cTw=; b=oPwh4c/zTjuWZmq7NjKKIXgKdyff6nR7rME5CnLwBG1G3QH6L5+nzQZ7IZBzIMvLvc L1SjybRbT+ihleoC3HZT+7VrpugYq6iYV6mN+a+2IRmdbbPYjJw2NjETTIYIvCL8bwM9 qi1nUWjase7GpuB0iL/aIpFqV5bxGb36JeN+p6faXyBD7HlI/mW3+2eYyCsbVxN/pv27 s3JIoDf4Ahx03U5SEy5SZhhDpO69NG2J7ewYXPnEFhLnYfoZEGEFN8YfM6yC8sZvgZvq 5pTGjPOjoWYRwsVfXQRW566f/bq3FvVHwUqNtJ2dCIhnRXfOqjsPDrpJZkU4Wuis/sYW LcNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d16si14463795ilf.112.2021.06.29.19.27.38; Tue, 29 Jun 2021 19:27:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232093AbhF3CB4 (ORCPT + 99 others); Tue, 29 Jun 2021 22:01:56 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:9321 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231770AbhF3CB4 (ORCPT ); Tue, 29 Jun 2021 22:01:56 -0400 Received: from dggeme766-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GF4DJ6Rc0z73kS; Wed, 30 Jun 2021 09:55:12 +0800 (CST) Received: from huawei.com (10.175.104.82) by dggeme766-chm.china.huawei.com (10.3.19.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 30 Jun 2021 09:59:24 +0800 From: Wang Hai To: , , , , CC: , , , Subject: [PATCH -next] clk: stm32mp1: fix missing spin_lock_init() Date: Wed, 30 Jun 2021 09:58:23 +0800 Message-ID: <20210630015824.2555840-1-wanghai38@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.82] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme766-chm.china.huawei.com (10.3.19.112) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. Fixes: c392df194a2d ("clk: stm32mp1: move RCC reset controller into RCC clock driver") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/clk/clk-stm32mp1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c index 6adc625e79c..256575bd29b 100644 --- a/drivers/clk/clk-stm32mp1.c +++ b/drivers/clk/clk-stm32mp1.c @@ -2263,6 +2263,7 @@ static int stm32_rcc_reset_init(struct device *dev, void __iomem *base, if (!reset_data) return -ENOMEM; + spin_lock_init(&reset_data->lock); reset_data->membase = base; reset_data->rcdev.owner = THIS_MODULE; reset_data->rcdev.ops = &stm32_reset_ops; -- 2.17.1