Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Jun 2021 09:42:05 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Yunus Bas <Y.Bas@phytec.de>
Cc:     "stwiss.opensource@diasemi.com" <stwiss.opensource@diasemi.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning
 to debug
Message-ID: <YNwuXWGe8am89Bn9@dell>
References: <20210616081949.26618-1-y.bas@phytec.de>
 <YMm+VXRrRKIHGgmr@dell>
 <5a3f5fd82a391ade9a659338983e5efa7924210d.camel@phytec.de>
 <YMsHXEP36Vxr7lAb@dell>
 <03cb3befabdda032b1ec9d97b4daac69fa23c759.camel@phytec.de>
 <YNsid9K4PdUJbKqs@dell>
 <5a718e7812f2ce46347ae94fda6175f38c65359e.camel@phytec.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5a718e7812f2ce46347ae94fda6175f38c65359e.camel@phytec.de>
Precedence: bulk

> No. This is not about DA9061 or it's mfd_cell-entries at all. My
> concern is about the general behaviour of the MFD-framework and how
> mfd_cell entries with compatibles are initialized.

I'm still not 100% sure I understand your use-case.

Let's take this back to basics.

What device are you trying to instantiate?  A DA9062 derivative?

> > Actually, this has served to highlight that your DTS is not correct.
> > 
> > Why are some devices represented in DT and some aren't?
> > 
> > If anything, I'm tempted to upgrade the info() print to warn().
> > 
> 
> Imagine only required parts of the MFD is connected to the designed
> system and unrequired parts are not. In that case, fully describing the
> MFD in the devicetree wouldn't represent the system at all.
> 
> Actually it would make more sense to check if mfd_cell-entries with
> compatibles are represented in the devicetree and add them after
> matching. This way the warning would serve it's purpose. What do you
> think of it?

I think the DT and MFD should match, so again, the way I currently
view this, doing it this way is just a different way to paper over the
cracks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog