Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp136355pxv; Wed, 30 Jun 2021 01:47:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKpDxO5EO8OFpIdh0Ui/tvp8OIN/52TRyaDAhbQLa87n8fzcWZEd9UxjGKTKxr+r7FGKBy X-Received: by 2002:a17:906:2642:: with SMTP id i2mr16061717ejc.323.1625042826642; Wed, 30 Jun 2021 01:47:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625042826; cv=none; d=google.com; s=arc-20160816; b=XbJSazUgC+BxKFcFsLg/yZ0Ei3GEjCs0LxiJ/V4JdCnU5ZlbJeqhregMNdv0Gvoyyr Gd1dpkIZ5eaufSGx3WDSv9gOa80YfEUzd5/EO4nmFJE+ZmACZoouH7gCPc92tM8ecflH MmXSxBo+yVY7YqMN+dvLi9YUOr2v3wjBo61BB58xu7Hmk/VubKrPaLtAb3rZJMpDalBB gw4kR3VZwLOXK6vE8SKRrvs3JARml8HMa0nnuCfK2IGQq+cn4k1+9fexEQnpSUfW+qRT oz0/ehsAkvYos6LTZs/3rxMoPm2dkAEHawjSNxcn6ZY5OzafHPi5mj38c4azre5iuBbL gusQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:date :subject:cc:to:from; bh=31eEvVXDwkiKqlPE5Gdjmxb/PB+3dxmwLlP1LaiXP0c=; b=d3v0E9yIZMOiVhn1vG5XdqGUaZSATWeSglOacKFq2Ud1+9IRXm2jL7py80P9hKPjLm cY94WRvCT0Vdb84jNQTU+9+weIQLx8y67+mCkrlfXBJ4Y+qlAkY5FKMnHOePi7Va1/4d GkQeBy4h4GWk/Y4QqEvNjM7pIYkAw81oazeheykB+NUKuIP2eugG3xmwW/JjSDpwhwZa a1bo4NjBV/QjAS66EMYktBC/ZXIVPU2GI9IdV5LzxYEAnZyYy0xWlarxKQPLMRPu9b43 yNFqVVnNAt9SexNoV2mnfr4/p5kgfPsel/LmuEMX7n6KN2HJEl7gDu/Ezm1nFKAltUSw No0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=puri.sm Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u19si20573132edq.591.2021.06.30.01.46.43; Wed, 30 Jun 2021 01:47:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=puri.sm Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233651AbhF3IsJ (ORCPT + 99 others); Wed, 30 Jun 2021 04:48:09 -0400 Received: from comms.puri.sm ([159.203.221.185]:59142 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233536AbhF3IsG (ORCPT ); Wed, 30 Jun 2021 04:48:06 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id D4AFBDF765; Wed, 30 Jun 2021 01:45:07 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ZoC0VD6kptH; Wed, 30 Jun 2021 01:45:03 -0700 (PDT) From: Martin Kepplinger To: martin.kepplinger@puri.sm, bvanassche@acm.org Cc: jejb@linux.ibm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, kernel@puri.sm, stern@rowland.harvard.edu Subject: [PATCH v5 0/3] fix runtime PM for SD card readers Date: Wed, 30 Jun 2021 10:44:50 +0200 Message-Id: <20210630084453.186764-1-martin.kepplinger@puri.sm> Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, (According to Alan Stern, "as far as I know, all") SD card readers send MEDIA_CHANGED unit attention notification on (runtime) resume. We cannot use runtime PM with these devices as I/O always fails in that case. This fixes runtime PM for SD cardreaders. I'd appreciate any feedback. To enable runtime PM for an SD cardreader number 0:0:0:0, do: echo 0 > /sys/module/block/parameters/events_dfl_poll_msecs echo 1000 > /sys/bus/scsi/devices/0:0:0:0/power/autosuspend_delay_ms echo auto > /sys/bus/scsi/devices/0:0:0:0/power/control thank you, martin revision history ---------------- v5: (thank you Bart) * simplify the sense request itself and remove unnecessary code v4: (thank you Bart and Alan) * send SENSE REQUEST in sd instead of adding a global scsi error flag. https://lore.kernel.org/linux-scsi/20210628133412.1172068-1-martin.kepplinger@puri.sm/T/#t v3: (thank you Bart) * create a new BLIST entry to mark affected devices instead of the sysfs module parameter for sd only. still, only sd implements handling the flag for now. * cc linux-pm list https://lore.kernel.org/linux-scsi/20210328102531.1114535-1-martin.kepplinger@puri.sm/ v2: https://lore.kernel.org/linux-scsi/20210112093329.3639-1-martin.kepplinger@puri.sm/ * move module parameter to sd * add Documentation v1: https://lore.kernel.org/linux-scsi/20210111152029.28426-1-martin.kepplinger@puri.sm/T/ For the full background, the discussion started in June 2020 here: https://lore.kernel.org/linux-scsi/20200623111018.31954-1-martin.kepplinger@puri.sm/ Martin Kepplinger (3): scsi: devinfo: add new flag BLIST_MEDIA_CHANGE scsi: sd: send REQUEST SENSE for BLIST_MEDIA_CHANGE devices in runtime_resume() scsi: devinfo: add BLIST_MEDIA_CHANGE for Ultra HS-SD/MMC usb cardreaders drivers/scsi/scsi_devinfo.c | 1 + drivers/scsi/sd.c | 26 +++++++++++++++++++++++++- include/scsi/scsi_devinfo.h | 6 +++--- 3 files changed, 29 insertions(+), 4 deletions(-) -- 2.30.2