Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755403AbWKNDDM (ORCPT ); Mon, 13 Nov 2006 22:03:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755406AbWKNDDM (ORCPT ); Mon, 13 Nov 2006 22:03:12 -0500 Received: from gate.crashing.org ([63.228.1.57]:19923 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S1755403AbWKNDDL (ORCPT ); Mon, 13 Nov 2006 22:03:11 -0500 Subject: Re: [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X From: Benjamin Herrenschmidt To: Ian Romanick Cc: David Miller , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, anton@samba.org, airlied@gmail.com, paulus@samba.org In-Reply-To: <455926C0.9080906@us.ibm.com> References: <1163405790.4982.289.camel@localhost.localdomain> <20061113.163138.98554015.davem@davemloft.net> <455926C0.9080906@us.ibm.com> Content-Type: text/plain Date: Tue, 14 Nov 2006 14:02:51 +1100 Message-Id: <1163473371.5940.84.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 22 > > So the gist of your change is that X isn't obtaining BAR values > > in the correct context on powerpc, and so you're going to hack up > > the "devices" files output to "help" X out. > > > > This doesn't sound sane to me. > > It doesn't sound terribly sane to me. What's wrong with just opening > /sys/bus/pci/devices/*/resource[0-5]? It seems like that solves all the > problems. We have to, that's how we get current X to work. Of course it will be much better once X uses sysfs, no question about that. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/