Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210618072349.503-1-xuewen.yan94@gmail.com> <87fsx093vm.mognet@arm.com>
 <CAB8ipk9TMTbw2WGrbLuewk_CaYxrvMOp2Ui5xiHiwYB4NmoRhA@mail.gmail.com> <87czs38u72.mognet@arm.com>
In-Reply-To: <87czs38u72.mognet@arm.com>
From:   Xuewen Yan <xuewen.yan94@gmail.com>
Date:   Wed, 30 Jun 2021 20:05:37 +0800
Message-ID: <CAB8ipk8tdA7tB3yJQSeVW1vz6W9PDzqWoU3tv2XdDcoSrhbEqA@mail.gmail.com>
Subject: Re: [PATCH] sched/uclamp: Fix getting unreasonable ucalmp_max when rq
 is idle
To:     Valentin Schneider <valentin.schneider@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Benjamin Segall <bsegall@google.com>,
        Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Patrick Bellasi <patrick.bellasi@matbug.net>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Quentin Perret <qperret@google.com>,
        Qais Yousef <qais.yousef@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 30, 2021 at 7:31 PM Valentin Schneider
<valentin.schneider@arm.com> wrote:
>
> On 30/06/21 09:24, Xuewen Yan wrote:
> > On Tue, Jun 29, 2021 at 9:50 PM Valentin Schneider
> > <valentin.schneider@arm.com> wrote:
> >> +       min_util =3D max_t(unsigned long, min_util, READ_ONCE(rq->ucla=
mp[UCLAMP_MIN].value));
> >> +       max_util =3D max_t(unsigned long, max_util, READ_ONCE(rq->ucla=
mp[UCLAMP_MAX].value));
> >
> > Is it necessary to use max_t here? although it is not the main problem.=
..
> >
>
> I got comparison warnings when using a regular max() - the RQ clamp value=
s
> are unsigned int, whereas the local variable is unsigned long.

Yes=EF=BC=8CI miss the rq clamp value's type.

Thanks!
xuewen