Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp261455pxv; Wed, 30 Jun 2021 05:11:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdcYIS4h4WiC3t7fbWiXHu0VXJvoTedSwOD8kWOgEZTCm9CKC/dKzoMJ26JvN0NfzV/fZV X-Received: by 2002:a5d:9acb:: with SMTP id x11mr7635815ion.133.1625055090079; Wed, 30 Jun 2021 05:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625055090; cv=none; d=google.com; s=arc-20160816; b=bN6qGJ98i2Knpk5tC6tdYkvJoFjjvqFO+4q4/uZzdAzx7gBoKKgx+cqv9EL/Aadwll /tdAgbQhcbvrZUj9nx1PYwWrfgyvqO4+qCYD9PTI8Hjxo7Ywe0HKu7eBGPVnKJ3REoUH whgzAHJkwkaG9M601qjhsuTpSMDsAI5ybK/k25t9c5QomzB1bbZvEsCg5AK9MP21G+Va C0LiD+6BM4n6y6UWoEVPDbbwG2lq7EVhoDrPCHoPho6wWXiLflLh7jZaQOHlZ/TgWoB1 n2nvt4pgqKuVKpIvhpWbza6lkQYTbqAWFsucxfrhTkb6J/6ZmyyFoxHCmHty8d6ZKOYX BDDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=FJTO6pxPtAux1cBQLRZjxVCHzgLURkHrLn9qCI89L18=; b=k9ZRN/V9gxP4FSdbMx5zvZlek++XDQCO2NP0biLUhSPh4ldBLJWg9Gxh1c2QliPaFu As+Kignh47ihC2i0XOIRnTHy/rs7cCfIbeTsE+7SGmXYtbkOkBALKMzYCIMLlXF5X+Os 4zpOgPjIqNQAfqBaTXt9vu8r3V/EF87eSvhgy6PotOegaYxvjnoCioC+TWX3svTAJdHu T53Es+ffKaQFh+5xkVqqNzgdjEMzQsyYitAayp12O540PwdLqWJDSSKmSqfqNiTCNtrQ lthKUV3imHAXwwcraVKDTv6TbxVcGxZHx6magYAJ3lXLPPWL5MceIn9+gQw3LHydZ4D5 D+4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si21162880ilu.2.2021.06.30.05.11.16; Wed, 30 Jun 2021 05:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234450AbhF3MMU (ORCPT + 99 others); Wed, 30 Jun 2021 08:12:20 -0400 Received: from mail.netfilter.org ([217.70.188.207]:36466 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234309AbhF3MMT (ORCPT ); Wed, 30 Jun 2021 08:12:19 -0400 Received: from netfilter.org (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id 24E9460777; Wed, 30 Jun 2021 14:09:44 +0200 (CEST) Date: Wed, 30 Jun 2021 14:09:47 +0200 From: Pablo Neira Ayuso To: Vasily Averin Cc: Florian Westphal , Jozsef Kadlecsik , Taehee Yoo , Julian Anastasov , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH NETFILTER] netfilter: nfnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo Message-ID: <20210630120947.GA12739@salvia> References: <65205a04-f1a3-9901-f6b7-eab8f482f37f@virtuozzo.com> <20210630094949.GA18022@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210630094949.GA18022@breakpoint.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 30, 2021 at 11:49:49AM +0200, Florian Westphal wrote: > Vasily Averin wrote: > > Two patches listed below removed ctnetlink_dump_helpinfo call from under > > rcu_read_lock. Now its rcu_dereference generates following warning: > > ============================= > > WARNING: suspicious RCU usage > > 5.13.0+ #5 Not tainted > > ----------------------------- > > net/netfilter/nf_conntrack_netlink.c:221 suspicious rcu_dereference_check() usage! > > Reviewed-by: Florian Westphal I don't see this patch in netfilter's patchwork nor in netfilter-devel@vger.kernel.org Where did they go?