Subject: Re: [PATCH 2/2] Use dev_sysdata for ACPI and remove firmware_data
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Len Brown <lenb@kernel.org>
Cc: Greg KH <greg@kroah.com>, Linux Kernel list <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@osdl.org>
In-Reply-To: <200611140043.30714.len.brown@intel.com>
References: <1163033916.28571.803.camel@localhost.localdomain>
	 <20061110054944.GB9137@kroah.com>  <200611140043.30714.len.brown@intel.com>
Content-Type: text/plain
Date: Tue, 14 Nov 2006 16:50:13 +1100
Message-Id: <1163483414.5940.110.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1157
Lines: 32


> device.firmware_data was born when we went to link Linux devices
> and ACPI devices using device.platform_data and found it was already used.
> You recommended we create a new field to avoid the conflict, and
> IIR the discussion suggested that eventually device.platform_data use
> would get cleaned up and the fields could perhaps some day be combined.
> 
> I don't know if we are any closer to that day, before or after this change.

I've audited use of platform data and plan to get rid of it too :-)

(Or actually move it to platform_device where it belongs and fix other
abusers)

> However, I'm fine with Ben's re-name -- it changes no functionality on ACPI-enabled
> systems while potentially deleting an unused pointer/dev on other architectures.
> 
> Please ship his patch #2 along with patch #1 that it depends on.
> 
> Acked-by: Len Brown <len.brown@intel.com>

Excellent, thanks !

Cheers,
Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/