Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933199AbWKNIUk (ORCPT ); Tue, 14 Nov 2006 03:20:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933211AbWKNIUk (ORCPT ); Tue, 14 Nov 2006 03:20:40 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:36001 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S933199AbWKNIUj (ORCPT ); Tue, 14 Nov 2006 03:20:39 -0500 Subject: Re: [patch] irq: do not mask interrupts by default From: Arjan van de Ven To: Ingo Molnar Cc: "Eric W. Biederman" , Linus Torvalds , Komuro , tglx@linutronix.de, Adrian Bunk , Andrew Morton , Linux Kernel Mailing List In-Reply-To: <1163492040.28401.76.camel@earth> References: <1162985578.8335.12.camel@localhost.localdomain> <20061108085235.GT4729@stusta.de> <7813413.118221162987983254.komurojun-mbn@nifty.com> <11940937.327381163162570124.komurojun-mbn@nifty.com> <1163450677.7473.86.camel@earth> <1163492040.28401.76.camel@earth> Content-Type: text/plain Organization: Intel International BV Date: Tue, 14 Nov 2006 09:20:23 +0100 Message-Id: <1163492423.15249.241.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1.1 (2.8.1.1-3.fc6) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 23 > so my patch changes the default irq-disable logic of /all/ controllers > to "delayed disable". (IRQ chips can still override this by providing a > different chip->disable method that just clones their ->mask method, if > it is absolutely sure that no IRQs can be lost while masked) > > So this patch has the worst-case effect of getting at most one 'extra' > interrupt after the IRQ line has been 'disabled' - at which point the > line will be masked for real (by the flow handler). (I updated the > fasteoi and the simple irq flow handlers to mask the IRQ for real if an > IRQ triggers and the line was disabled.) since disable_irq() is used as locking against interrupt context by several drivers (*cough* ne2000 *cough*) I am not entirely convinced this is a good idea.... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/