Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Liam Beguin <lvb@xiphos.com>
To:     Wang Hai <wanghai38@huawei.com>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>
CC:     "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] clk: lmk04832: fix return value check in
 lmk04832_probe()
Thread-Topic: [PATCH -next] clk: lmk04832: fix return value check in
 lmk04832_probe()
Thread-Index: AQHXbVRCiolFjIE7Iki/bk8doP3i9asst/Vg
Date:   Wed, 30 Jun 2021 16:03:02 +0000
Message-ID: <YQBPR0101MB1811C2E16F1D6F2E9D474CAAD8019@YQBPR0101MB1811.CANPRD01.PROD.OUTLOOK.COM>
References: <20210630020322.2555946-1-wanghai38@huawei.com>
In-Reply-To: <20210630020322.2555946-1-wanghai38@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YqDpO/yYFziMOkrt8qfV032nCy2+UCgEbcYFP5Wssk5CVx3xxaihwbZfhOr5?=
 =?us-ascii?Q?gfxt/bYt9SjdNdurlganYLY6JV9D+bVGna+erO30nvmbh3wvc2iB9cPn0Bh2?=
 =?us-ascii?Q?pFBsa0Zq9GXG9pwyX3FkAwG6kRLlt1dwXwUU0YmttJe5PWagj8ZjeqBKsbIW?=
 =?us-ascii?Q?K3WBQDDFsAMOWPh+DLaHs/pPwGSYP709bc5x+9lPYRZiyp2b+7T4pJz/FCoU?=
 =?us-ascii?Q?OrzKyZCn5ZarfS6/cgcS5nq5zzEjOIcSH0hChgtXjrZkKAbwlmdboH0D/Aud?=
 =?us-ascii?Q?QwG1vPeSE/sPIJ6kyRBEgB3Ua20JmwfkHfVOZHtWGDARvl50AFWZEflvG1/A?=
 =?us-ascii?Q?545wsYd0kDIg2Tn8gNEaA5pSZPWpsRe3gUdm5N3DPfTQtH/yjJIXQPKlBpUw?=
 =?us-ascii?Q?+tqVr6bUv6XMtm9NIufsi7iiEFDdncNHo6j3EKh6EDLmZFi7MyiCtLke69u1?=
 =?us-ascii?Q?jcPb8plmLeIiiZzVHP+vpU3fKiZQpBqoPwg+ECbLcmb/KhsNh2hiPYtsV/uc?=
 =?us-ascii?Q?rW4Ri1p0jCR/BjrtM/fQqvtL1n+pSGmrBC9pkFzCSvuFtyKkeHoauqFilNyZ?=
 =?us-ascii?Q?GQ3HpCOydEOjIdZbVKvGIactU1PNmy2jAwVUfVVQO+hF7O+VqEmiO+NFjrUK?=
 =?us-ascii?Q?GvyCMfC/+AYtqUxj9F3z17jB2cZzYYksR9zaNQtwPBglmO7t4FEq+nK9GNi1?=
 =?us-ascii?Q?3m3t3vmodsnchKZvZVxEm5hizd46f0MPXzpexd5ZC8ueFL/KmqsH3xulgO92?=
 =?us-ascii?Q?lz7er2yIvyrKUm92UJrA8xFX0umj3SvLbecjTqgKPjQNhTFX+zK5Ooym5zf9?=
 =?us-ascii?Q?QRsUglpRRKdGhGUihIw+wB6VrEUVquC2hkXnlXDCBxfX2go/kE9pKoNT8ujf?=
 =?us-ascii?Q?om0g0jpbalfpw08CGYXHKrBYt6suUuG7DI6L3IRDVF+weDmz6gsH+AAT9FCa?=
 =?us-ascii?Q?nTvd2szlOnxebW0zaB27n7B4LSQ0h1FcFudTr6Wq0ZEylVw3j1J2iI/lk+QI?=
 =?us-ascii?Q?H6L6cZxcSzG6KOs7mshRx5JVQXx0c+bhFm5BBtS5d820QP9gln0YwiI2OhNq?=
 =?us-ascii?Q?yM/A7++Al/dJ/z/XhmsfKnEBxCkFmqPslZqUk0Z5oknpREHINTYqbvG/uiKf?=
 =?us-ascii?Q?HQCkMPqeaJczYARHyvVf+Rz+uto2QR8AliN2EvoJnvieZYK9phf7CyKlSoOY?=
 =?us-ascii?Q?2V47WfTLYLz3u2Jc7GPKZ5xi4U9lpNKjxbOlZ0zOijzHzDj7WeNITHVf92Q6?=
 =?us-ascii?Q?NV5KQbE/42uQ3ZV9PnvCNpceGHy9YfvnlE7Ae3wlpVgtvMOnXHoz2lQSzrNu?=
 =?us-ascii?Q?61fswl5NADyxymERK87bzTWb?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xiphos.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: YQBPR0101MB1811.CANPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: a6ca5726-8c3f-454d-2bc6-08d93be08a5d
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2021 16:03:02.8692
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 11c32550-fdb1-48d9-8a3d-133e5b75b54f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LS5J5n87VP2zQJ9Ow9kCbw+HN6b+g/pQAv4mCqpzcsbR5R8QPxNWOjBlEEw85ja6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB4691
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Wang Hai <wanghai38@huawei.com>
> Sent: June 29, 2021 10:03 PM
> To: mturquette@baylibre.com; sboyd@kernel.org; Liam Beguin
> <lvb@xiphos.com>
> Cc: linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH -next] clk: lmk04832: fix return value check in
> lmk04832_probe()
>=20
> In case of error, the function devm_kzalloc() and devm_kcalloc() return
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>=20
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

Reviewed-by: Liam Beguin <lvb@xiphos.com>

> ---
>  drivers/clk/clk-lmk04832.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
> index 0cd76e626c3..66ad5cbe702 100644
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1425,23 +1425,23 @@ static int lmk04832_probe(struct spi_device
> *spi)
>=20
>  	lmk->dclk =3D devm_kcalloc(lmk->dev, info->num_channels >> 1,
>  				 sizeof(struct lmk_dclk), GFP_KERNEL);
> -	if (IS_ERR(lmk->dclk)) {
> -		ret =3D PTR_ERR(lmk->dclk);
> +	if (!lmk->dclk) {
> +		ret =3D -ENOMEM;
>  		goto err_disable_oscin;
>  	}
>=20
>  	lmk->clkout =3D devm_kcalloc(lmk->dev, info->num_channels,
>  				   sizeof(*lmk->clkout), GFP_KERNEL);
> -	if (IS_ERR(lmk->clkout)) {
> -		ret =3D PTR_ERR(lmk->clkout);
> +	if (!lmk->clkout) {
> +		ret =3D -ENOMEM;
>  		goto err_disable_oscin;
>  	}
>=20
>  	lmk->clk_data =3D devm_kzalloc(lmk->dev, struct_size(lmk->clk_data,
> hws,
>  							   info-
> >num_channels),
>  				     GFP_KERNEL);
> -	if (IS_ERR(lmk->clk_data)) {
> -		ret =3D PTR_ERR(lmk->clk_data);
> +	if (!lmk->clk_data) {
> +		ret =3D -ENOMEM;
>  		goto err_disable_oscin;
>  	}
>=20
> --
> 2.17.1