Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Jun 2021 19:29:33 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com,
        Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v2 08/31] EDAC/amd64: Define function to read DRAM
 address map registers
Message-ID: <YNyp/ZsGwnjFZr04@zn.tnic>
References: <20210623192002.3671647-1-yazen.ghannam@amd.com>
 <20210623192002.3671647-9-yazen.ghannam@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210623192002.3671647-9-yazen.ghannam@amd.com>
Precedence: bulk

On Wed, Jun 23, 2021 at 07:19:39PM +0000, Yazen Ghannam wrote:
> @@ -1170,22 +1194,13 @@ static int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr
>  	if (remove_dram_offset(&ctx))
>  		goto out_err;
>  
> -	reg = df_regs[DRAM_BASE_ADDR];
> -	reg.offset += ctx.map_num * 8;
> -	if (amd_df_indirect_read(nid, reg, umc, &tmp))
> -		goto out_err;
> -
> -	/* Check if address range is valid. */
> -	if (!(tmp & BIT(0))) {
> -		pr_err("%s: Invalid DramBaseAddress range: 0x%x.\n",
> -			__func__, tmp);
> +	if (get_dram_addr_map(&ctx))
>  		goto out_err;
> -	}

Aha, I see where you're going with the context struct. Yap, ok.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette