Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210629112748.23734-1-zhangliguang@linux.alibaba.com>
In-Reply-To: <20210629112748.23734-1-zhangliguang@linux.alibaba.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 30 Jun 2021 20:02:11 +0200
Message-ID: <CAJZ5v0j3oCqW-D-Z3jRP9w8uETsYjxB+=Tsm3-B5FNOYR1QgeQ@mail.gmail.com>
Subject: Re: [PATCH] ACPI / amba: Fix resource name in /proc/iomem
To:     Liguang Zhang <zhangliguang@linux.alibaba.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 29, 2021 at 1:28 PM Liguang Zhang
<zhangliguang@linux.alibaba.com> wrote:
>
> In function amba_handler_attach(), dev->res.name is initialized by
> amba_device_alloc. But when address_found is false, dev->res.name is
> assigned to null value, which leads to wrong resource name display in
> /proc/iomem, "<BAD>" is seen for those resources.
>
> Signed-off-by: Liguang Zhang <zhangliguang@linux.alibaba.com>
> ---
>  drivers/acpi/acpi_amba.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c
> index 49b781a9cd97..ab8a4e0191b1 100644
> --- a/drivers/acpi/acpi_amba.c
> +++ b/drivers/acpi/acpi_amba.c
> @@ -76,6 +76,7 @@ static int amba_handler_attach(struct acpi_device *adev,
>                 case IORESOURCE_MEM:
>                         if (!address_found) {
>                                 dev->res = *rentry->res;
> +                               dev->res.name = dev_name(&dev->dev);
>                                 address_found = true;
>                         }
>                         break;
> --

Applied as 5.14-rc1 material, thanks!