Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp539404pxv; Wed, 30 Jun 2021 11:20:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaU3rgCO44Zcufiu8NS9j+nTMgVasjhroWaAeXB2QqKV8/eOuUQCcO5VgJs1cjnnXWqihL X-Received: by 2002:a92:7d07:: with SMTP id y7mr27008574ilc.68.1625077237043; Wed, 30 Jun 2021 11:20:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625077237; cv=none; d=google.com; s=arc-20160816; b=iQPOyJTt2WdhS6YIVyiRAwnWKLbeHobrd7cImH53pySZCx2+rjvFNCAFMHcWeFzFVc goo/UAFzZ0pgbxPqLHG2JlPeLx7ehdj3y80sNLVR0ZcsMpbVsV/FTK0v7aVFq+h2JR2A fDD27VezRXsdnVaTpNQZh7Dp4om4Bkv2t4V8QmK6dX+AwdKdnALNulMavqFozLi3iUvx WlzkMx06RAH/v52zwmNz/edSmBGFr5G0LLGMCjehrqU1sUafl6/kaaPvlJd/3ux8+D2p MMth9WdfkjOIexxELxLpwJy23RNGKksOPoJvjYmIW8ZBcVJa3fDI56PNxbCssQwm37hD U+ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=k716vSAadTFPAw6m1tRKqa78k3IKWlFrre5nAMX7UdA=; b=A9IeFvGereFEF12wmZX/Eg/RhskH9UeDzBjAs+u6pEHQsOMFa/mLbEqAhKKEkZWXyc +G1tt7qWisz9fqUyTEZGhtWBR6C8HcbxW9wwkZ3Q7lsbnwVQBLvKdtzWGYEONaIEUOoF M5gStreKRI1Yq+lLL1NJruAfga517Xp8o+RfMxUmN3DCUP9OrvGydl9dXNuiDs9sPdrT oB+TIHLR15DVdYU5dnKg/bqXKVqBfH6cSii8fw8rlPWTATHEiTIDVOTSE/suzlwwfeWP CMdVk6FWONveV8IdwoLd4H4BV+zhEWyyO6xlcyKqwGSJN3DaiMRbGCC5StEaeVUmy2Eu LxcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Y/hKntSL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n14si5559451ili.18.2021.06.30.11.20.22; Wed, 30 Jun 2021 11:20:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Y/hKntSL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232745AbhF3SVG (ORCPT + 99 others); Wed, 30 Jun 2021 14:21:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:35182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbhF3SVE (ORCPT ); Wed, 30 Jun 2021 14:21:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AC2C861159; Wed, 30 Jun 2021 18:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625077115; bh=k716vSAadTFPAw6m1tRKqa78k3IKWlFrre5nAMX7UdA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Y/hKntSLE5TI4906/U2vzFdLCRTQbzk/vWRznu2k+j45ON6XpwiU3x4AxsN33A5tb Rp3dVzD8Vs7Pb36uiQZo/q3H4lN7uyTxkcbOXSz/rNnVj2PtLRU+Q5qVrB7/bEPoOJ m9m0v74i2YLQPXliBCvVyqPaHnwg2tosh/eiPhZKwxJU8a822pA/tN/w9m8OwyJHbC NcT3cFZqahT7P+2tT9FY2BHlsn7syVST5NIzzWBakuH9ryPZtrhUBPuJxJhAnOvlks vfjK4iWyujIfrXKSV+QaP0UQPmnx9WlK4u28n3Xm5zxCUe5N/asuDv0jDJzq+krtck SrI4WO2lo5IpQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210630020322.2555946-1-wanghai38@huawei.com> References: <20210630020322.2555946-1-wanghai38@huawei.com> Subject: Re: [PATCH -next] clk: lmk04832: fix return value check in lmk04832_probe() From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Wang Hai , lvb@xiphos.com, mturquette@baylibre.com Date: Wed, 30 Jun 2021 11:18:34 -0700 Message-ID: <162507711455.3331010.7831190546024557147@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Wang Hai (2021-06-29 19:03:22) > In case of error, the function devm_kzalloc() and devm_kcalloc() return > NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. >=20 > Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- Applied to clk-next