Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hongwei Zhang <hongweiz@ami.com>
To:     Michael Walle <michael@walle.cc>
CC:     Hongwei Zhang <hongweiz@ami.com>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
Date:   Wed, 30 Jun 2021 14:20:59 -0400
Message-ID: <20210630182059.29699-1-hongweiz@ami.com>
In-Reply-To: <20210629150846.21547-2-hongweiz@ami.com>
References: <20210629150846.21547-1-hongweiz@ami.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi Michael,

>Subject:	[EXTERNAL] Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids
>
>Hi Hongwei,
>
>Am 2021-06-29 17:08, schrieb Hongwei Zhang:
>> Add some Micron M45PEx flash memeories into the IDs table.
>
>Did you test all these flashes?
>
No, the patch was added in porting drivers related to AST2600 EVB.

>> Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections
>> for
>> eMMC)
>
>Bogus Fixes tag. First, I cannot find this commit id, which tree is
>that? Secondly, adding new flash ids don't fix anything, esp not
>something related to eMMC.
>
Sorry for the confusion, I thought Fixes tag could be also used for referencing
the revision base for the patch to aplly on.
I used dev-5.10 branch from https://github.com/openbmc/linux.git , should I
use a different repository?

Thanks,
--Hongwei
>>
>> Signed-off-by: Hongwei Zhang <hongweiz@ami.com>
>> ---
>>  drivers/mtd/spi-nor/micron-st.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/micron-st.c
>> b/drivers/mtd/spi-nor/micron-st.c
>> index ef3695080710..379b14e339ff 100644
>> --- a/drivers/mtd/spi-nor/micron-st.c
>> +++ b/drivers/mtd/spi-nor/micron-st.c
>> @@ -95,8 +95,12 @@ static const struct flash_info st_parts[] = {
>>       { "m25p128-nonjedec", INFO(0, 0, 256 * 1024,  64, 0) },
>>
>>       { "m45pe10", INFO(0x204011,  0, 64 * 1024,    2, 0) },
>> +     { "m45pe20", INFO(0x204012,  0, 64 * 1024,    4, 0) },
>> +     { "m45pe40", INFO(0x204013,  0, 64 * 1024,    8, 0) },
>>       { "m45pe80", INFO(0x204014,  0, 64 * 1024,   16, 0) },
>>       { "m45pe16", INFO(0x204015,  0, 64 * 1024,   32, 0) },
>> +     { "m45pe32", INFO(0x204016,  0, 64 * 1024,   64, 0) },
>> +     { "m45pe64", INFO(0x204017,  0, 64 * 1024,  128, 0) },
>>
>>       { "m25pe20", INFO(0x208012,  0, 64 * 1024,  4,       0) },
>>       { "m25pe80", INFO(0x208014,  0, 64 * 1024, 16,       0) },
>
>--
>-michael
>