Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp588707pxv; Wed, 30 Jun 2021 12:37:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhY/5PqNyAYUB92zQtqj8ye0kKDzgdqPBAK05Yn7iXrsBV8Xxyd5gxsoiCNI31Wm2A17l6 X-Received: by 2002:a17:907:76b9:: with SMTP id jw25mr11749933ejc.71.1625081862166; Wed, 30 Jun 2021 12:37:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625081862; cv=none; d=google.com; s=arc-20160816; b=jyZMnJWcvgaP5WWRm9cxXLUXELvw67vuWnzCq1Us1KznJqH7R/s28F1O7noDRisvmd AtLXaM2b62rzF2BCfVx5IZc2inSjYeP5AgurdY0wPN2nxZX+a/lckiS1xX3yL7Wa5J+o N38WZIEvrhmh9dQpBtY6Z5l1J4AU3cDattuXypDJAwUXLkcDQJnsqXZN93yg8/zMwOI+ TWl+O5J0mXlpJxTaHNehMiOwe/HyxFpwVeqYwsQiccEYl2WfUxnntfdN7+yd2TJF4sFC 5y/1v9qXbZojk2Zpgs6jd72Qd51J81r+5fSbH0RQITPidLLgQBAanD5LffqWkjoWA7GR S94Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=sTKLgVyaeKDi7bkOPNQ5KQlPXDbbyFhP7PAVGq4jic0=; b=gUE0eJT2BoQ6FdRNLEVyO3CjRpH2LXF1Tbs068gjaYUtRP2B3wG/NTv4Mhm0ixi6rr YkCyeXN0iAKUOFk56lf761AR6lg+yMyWFCFPBrJuibE58Jn8IIQU2214Ra2Wm1/wj0bq 74c6Kwk4oOWGluJxmto2EEoG4s9a+YAinqFacHgXCZmAm6zdvacBcwQAUMGNAOyEa91N uKyEu4auUE0nPxSVzSBHVPkR11X5VMw00dPKiXGZzIaMkmt6c74C/JA4mNdu/DPzeKMh +iu4f63+5HymXkYwuyV3SE5fEggQxp32RctNGbR0nn1kf1X0OlYuwuwyZ4M7wf3jL4vP TACg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e4si21335136ejy.484.2021.06.30.12.37.18; Wed, 30 Jun 2021 12:37:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233801AbhF3Tix (ORCPT + 99 others); Wed, 30 Jun 2021 15:38:53 -0400 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]:48799 "EHLO outpost1.zedat.fu-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229700AbhF3Tiw (ORCPT ); Wed, 30 Jun 2021 15:38:52 -0400 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.94) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1lyg0Q-002Tbr-BY; Wed, 30 Jun 2021 21:36:18 +0200 Received: from p57bd964c.dip0.t-ipconnect.de ([87.189.150.76] helo=[192.168.178.81]) by inpost2.zedat.fu-berlin.de (Exim 4.94) with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (envelope-from ) id 1lyg0Q-002W4E-0F; Wed, 30 Jun 2021 21:36:18 +0200 Subject: Re: [PATCH 3/3 v2] sh: fix READ/WRITE redefinition warnings To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Geert Uytterhoeven , Takashi YOSHII References: <20210627220544.8757-1-rdunlap@infradead.org> <20210627220544.8757-4-rdunlap@infradead.org> <6af41806-e715-4084-418f-4a8924d26c07@physik.fu-berlin.de> <8efd6e1d-9949-9598-9e6b-41d9b2f4ea7a@infradead.org> From: John Paul Adrian Glaubitz Message-ID: Date: Wed, 30 Jun 2021 21:36:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <8efd6e1d-9949-9598-9e6b-41d9b2f4ea7a@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.150.76 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/30/21 9:33 PM, Randy Dunlap wrote: > On 6/30/21 2:36 AM, John Paul Adrian Glaubitz wrote: >> On 6/28/21 12:05 AM, Randy Dunlap wrote: >>> kernel.h defines READ and WRITE, so rename the SH math-emu macros >>> to MREAD and MWRITE. >>> >>> Fixes these warnings: >>> >>> ../arch/sh/math-emu/math.c:54: warning: "WRITE" redefined >>> 54 | #define WRITE(d,a) ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;}) >>> In file included from ../arch/sh/math-emu/math.c:10: >>> ../include/linux/kernel.h:37: note: this is the location of the previous definition >>> 37 | #define WRITE 1 >>> ../arch/sh/math-emu/math.c:55: warning: "READ" redefined >>> 55 | #define READ(d,a) ({if(get_user(d, (typeof (d) __user *)a)) return -EFAULT;}) >>> In file included from ../arch/sh/math-emu/math.c:10: >>> ../include/linux/kernel.h:36: note: this is the location of the previous definition >>> 36 | #define READ 0 >>> >>> Fixes: 4b565680d163 ("sh: math-emu support") >>> Signed-off-by: Randy Dunlap >>> Cc: Yoshinori Sato >>> Cc: Rich Felker >>> Cc: linux-sh@vger.kernel.org >>> Cc: Takashi YOSHII >>> Cc: John Paul Adrian Glaubitz >>> Cc: Geert Uytterhoeven >>> --- >>> v2: renumber patches, otherwise no change; >>> >>> arch/sh/math-emu/math.c | 44 +++++++++++++++++++------------------- >>> 1 file changed, 22 insertions(+), 22 deletions(-) >>> >>> --- linux-next-20210625.orig/arch/sh/math-emu/math.c >>> +++ linux-next-20210625/arch/sh/math-emu/math.c >>> @@ -51,8 +51,8 @@ >>> #define Rn (regs->regs[n]) >>> #define Rm (regs->regs[m]) >>> >>> -#define WRITE(d,a) ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;}) >>> -#define READ(d,a) ({if(get_user(d, (typeof (d) __user *)a)) return -EFAULT;}) >>> +#define MWRITE(d,a) ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;}) >>> +#define MREAD(d,a) ({if(get_user(d, (typeof (d) __user *)a)) return -EFAULT;}) >>> >>> #define PACK_S(r,f) FP_PACK_SP(&r,f) >>> #define UNPACK_S(f,r) FP_UNPACK_SP(f,&r) >>> @@ -157,11 +157,11 @@ fmov_idx_reg(struct sh_fpu_soft_struct * >>> { >>> if (FPSCR_SZ) { >>> FMOV_EXT(n); >>> - READ(FRn, Rm + R0 + 4); >>> + MREAD(FRn, Rm + R0 + 4); >>> n++; >>> - READ(FRn, Rm + R0); >>> + MREAD(FRn, Rm + R0); >>> } else { >>> - READ(FRn, Rm + R0); >>> + MREAD(FRn, Rm + R0); >>> } >>> >>> return 0; >>> @@ -173,11 +173,11 @@ fmov_mem_reg(struct sh_fpu_soft_struct * >>> { >>> if (FPSCR_SZ) { >>> FMOV_EXT(n); >>> - READ(FRn, Rm + 4); >>> + MREAD(FRn, Rm + 4); >>> n++; >>> - READ(FRn, Rm); >>> + MREAD(FRn, Rm); >>> } else { >>> - READ(FRn, Rm); >>> + MREAD(FRn, Rm); >>> } >>> >>> return 0; >>> @@ -189,12 +189,12 @@ fmov_inc_reg(struct sh_fpu_soft_struct * >>> { >>> if (FPSCR_SZ) { >>> FMOV_EXT(n); >>> - READ(FRn, Rm + 4); >>> + MREAD(FRn, Rm + 4); >>> n++; >>> - READ(FRn, Rm); >>> + MREAD(FRn, Rm); >>> Rm += 8; >>> } else { >>> - READ(FRn, Rm); >>> + MREAD(FRn, Rm); >>> Rm += 4; >>> } >>> >>> @@ -207,11 +207,11 @@ fmov_reg_idx(struct sh_fpu_soft_struct * >>> { >>> if (FPSCR_SZ) { >>> FMOV_EXT(m); >>> - WRITE(FRm, Rn + R0 + 4); >>> + MWRITE(FRm, Rn + R0 + 4); >>> m++; >>> - WRITE(FRm, Rn + R0); >>> + MWRITE(FRm, Rn + R0); >>> } else { >>> - WRITE(FRm, Rn + R0); >>> + MWRITE(FRm, Rn + R0); >>> } >>> >>> return 0; >>> @@ -223,11 +223,11 @@ fmov_reg_mem(struct sh_fpu_soft_struct * >>> { >>> if (FPSCR_SZ) { >>> FMOV_EXT(m); >>> - WRITE(FRm, Rn + 4); >>> + MWRITE(FRm, Rn + 4); >>> m++; >>> - WRITE(FRm, Rn); >>> + MWRITE(FRm, Rn); >>> } else { >>> - WRITE(FRm, Rn); >>> + MWRITE(FRm, Rn); >>> } >>> >>> return 0; >>> @@ -240,12 +240,12 @@ fmov_reg_dec(struct sh_fpu_soft_struct * >>> if (FPSCR_SZ) { >>> FMOV_EXT(m); >>> Rn -= 8; >>> - WRITE(FRm, Rn + 4); >>> + MWRITE(FRm, Rn + 4); >>> m++; >>> - WRITE(FRm, Rn); >>> + MWRITE(FRm, Rn); >>> } else { >>> Rn -= 4; >>> - WRITE(FRm, Rn); >>> + MWRITE(FRm, Rn); >>> } >>> >>> return 0; >>> @@ -445,11 +445,11 @@ id_sys(struct sh_fpu_soft_struct *fregs, >>> case 0x4052: >>> case 0x4062: >>> Rn -= 4; >>> - WRITE(*reg, Rn); >>> + MWRITE(*reg, Rn); >>> break; >>> case 0x4056: >>> case 0x4066: >>> - READ(*reg, Rn); >>> + MREAD(*reg, Rn); >>> Rn += 4; >>> break; >>> default: >>> >> >> This one no longer applies to Linus' tree: >> >> glaubitz@node54:/data/home/glaubitz/linux> git am ../sh-patches-2021/\[PATCH\ 3_3\ v2\]\ sh\:\ fix\ READ_WRITE\ redefinition\ warnings.eml >> Applying: sh: fix READ/WRITE redefinition warnings >> error: patch failed: arch/sh/math-emu/math.c:51 >> error: arch/sh/math-emu/math.c: patch does not apply >> Patch failed at 0001 sh: fix READ/WRITE redefinition warnings >> hint: Use 'git am --show-current-patch=diff' to see the failed patch >> When you have resolved this problem, run "git am --continue". >> If you prefer to skip this patch, run "git am --skip" instead. >> To restore the original branch and stop patching, run "git am --abort". >> glaubitz@node54:/data/home/glaubitz/linux> > > OK. Thanks for all of the testing. I'll report back with the other patch applied that Geert mentioned from linux-next before this one. FWIW, there are some warnings when building the SH-7785LCR configuration: In file included from ./arch/sh/include/asm/hw_irq.h:6, from ./include/linux/irq.h:591, from ./include/asm-generic/hardirq.h:17, from ./arch/sh/include/asm/hardirq.h:9, from ./include/linux/hardirq.h:11, from ./include/linux/interrupt.h:11, from ./include/linux/serial_core.h:13, from ./include/linux/serial_sci.h:6, from arch/sh/kernel/cpu/sh4a/setup-sh7785.c:10: ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:107:9: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:478:8: note: in expansion of macro 'DECLARE_INTC_DESC' 478 | static DECLARE_INTC_DESC(intc_desc, "sh7785", vectors, groups, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:478:8: note: in expansion of macro 'DECLARE_INTC_DESC' 478 | static DECLARE_INTC_DESC(intc_desc, "sh7785", vectors, groups, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:105:31: note: in expansion of macro '_INTC_ARRAY' 105 | _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:132:15: note: in expansion of macro 'INTC_HW_DESC' 132 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:503:8: note: in expansion of macro 'DECLARE_INTC_DESC_ACK' 503 | static DECLARE_INTC_DESC_ACK(intc_desc_irq0123, "sh7785-irq0123", | ^~~~~~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:105:31: note: in expansion of macro '_INTC_ARRAY' 105 | _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:132:15: note: in expansion of macro 'INTC_HW_DESC' 132 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:507:8: note: in expansion of macro 'DECLARE_INTC_DESC_ACK' 507 | static DECLARE_INTC_DESC_ACK(intc_desc_irq4567, "sh7785-irq4567", | ^~~~~~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:105:31: note: in expansion of macro '_INTC_ARRAY' 105 | _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:535:8: note: in expansion of macro 'DECLARE_INTC_DESC' 535 | static DECLARE_INTC_DESC(intc_desc_irl0123, "sh7785-irl0123", vectors_irl0123, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:106:33: note: in expansion of macro '_INTC_ARRAY' 106 | _INTC_ARRAY(mask_regs), _INTC_ARRAY(prio_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:535:8: note: in expansion of macro 'DECLARE_INTC_DESC' 535 | static DECLARE_INTC_DESC(intc_desc_irl0123, "sh7785-irl0123", vectors_irl0123, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:107:9: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:535:8: note: in expansion of macro 'DECLARE_INTC_DESC' 535 | static DECLARE_INTC_DESC(intc_desc_irl0123, "sh7785-irl0123", vectors_irl0123, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:535:8: note: in expansion of macro 'DECLARE_INTC_DESC' 535 | static DECLARE_INTC_DESC(intc_desc_irl0123, "sh7785-irl0123", vectors_irl0123, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:105:31: note: in expansion of macro '_INTC_ARRAY' 105 | _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:538:8: note: in expansion of macro 'DECLARE_INTC_DESC' 538 | static DECLARE_INTC_DESC(intc_desc_irl4567, "sh7785-irl4567", vectors_irl4567, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:106:33: note: in expansion of macro '_INTC_ARRAY' 106 | _INTC_ARRAY(mask_regs), _INTC_ARRAY(prio_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:538:8: note: in expansion of macro 'DECLARE_INTC_DESC' 538 | static DECLARE_INTC_DESC(intc_desc_irl4567, "sh7785-irl4567", vectors_irl4567, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:107:9: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:538:8: note: in expansion of macro 'DECLARE_INTC_DESC' 538 | static DECLARE_INTC_DESC(intc_desc_irl4567, "sh7785-irl4567", vectors_irl4567, | ^~~~~~~~~~~~~~~~~ ./include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ ./include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ ./include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ arch/sh/kernel/cpu/sh4a/setup-sh7785.c:538:8: note: in expansion of macro 'DECLARE_INTC_DESC' 538 | static DECLARE_INTC_DESC(intc_desc_irl4567, "sh7785-irl4567", vectors_irl4567, | ^~~~~~~~~~~~~~~~~ -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913