Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210630051418.14044-1-jason-jh.lin@mediatek.com> <20210630051418.14044-4-jason-jh.lin@mediatek.com>
In-Reply-To: <20210630051418.14044-4-jason-jh.lin@mediatek.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Thu, 1 Jul 2021 07:21:45 +0800
Message-ID: <CAAOTY_9B1L=1=LzdC_1_czFgc4smH0hTk0B=XCquH08KAjx_nA@mail.gmail.com>
Subject: Re: [PATCH v1 3/5] arm64: dts: mt8195: add gce node
To:     "jason-jh.lin" <jason-jh.lin@mediatek.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DTML <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        hsinyi@google.com, Nancy Lin <nancy.lin@mediatek.com>,
        singo.chang@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Jason:

jason-jh.lin <jason-jh.lin@mediatek.com> =E6=96=BC 2021=E5=B9=B46=E6=9C=883=
0=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=881:18=E5=AF=AB=E9=81=93=EF=
=BC=9A
>
> add gce node on dts file.
>
> Change-Id: I805455cb7c645cb5a24ce1c87fe891a807069123
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
> This patch is based on [1]
> [1] Add Mediatek SoC MT8195 and evaluation board dts and Makefile
>     - https://patchwork.kernel.org/project/linux-mediatek/patch/202106010=
75350.31515-2-seiya.wang@mediatek.com/
> ---
>  arch/arm64/boot/dts/mediatek/mt8195.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/d=
ts/mediatek/mt8195.dtsi
> index c146a91c6272..38054196eea4 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -6,6 +6,7 @@
>
>  /dts-v1/;
>  #include <dt-bindings/clock/mt8195-clk.h>
> +#include <dt-bindings/gce/mt8195-gce.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/power/mt8195-power.h>
> @@ -717,6 +718,26 @@
>                         #clock-cells =3D <1>;
>                 };
>
> +               gce0: mdp_mailbox@10320000 {
> +                       compatible =3D "mediatek,mt8195-gce";
> +                       reg =3D <0 0x10320000 0 0x4000>;
> +                       interrupts =3D <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH 0=
>;
> +                       #mbox-cells =3D <3>;
> +                       clocks =3D <&infracfg_ao CLK_INFRA_AO_GCE>,
> +                                <&infracfg_ao CLK_INFRA_AO_GCE2>;
> +                       clock-names =3D "gce", "gce1";
> +               };
> +
> +               gce1: disp_mailbox@10330000 {
> +                       compatible =3D "mediatek,mt8195-gce";
> +                       reg =3D <0 0x10330000 0 0x4000>;
> +                       interrupts =3D <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH 0=
>;
> +                       #mbox-cells =3D <3>;
> +                       clocks =3D <&infracfg_ao CLK_INFRA_AO_GCE>,
> +                                <&infracfg_ao CLK_INFRA_AO_GCE2>;
> +                       clock-names =3D "gce", "gce1";

I think each gce could be broken into two function block, the core
function block and event processing block.
Each block has independent clock source and "gce" is for core function
block and "gce1" is for event processing block, is it?
If so, the core function of gce0 and gce1 has common clock source
(<&infracfg_ao CLK_INFRA_AO_GCE>), right?

Regards,
Chun-Kuang.

> +               };
> +
>                 uart0: serial@11001100 {
>                         compatible =3D "mediatek,mt8195-uart", "mediatek,=
mt6577-uart";
>                         reg =3D <0 0x11001100 0 0x100>;
> --
> 2.18.0
>