Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp169310pxv; Wed, 30 Jun 2021 17:52:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjYNJJN0aK9qh2rPKt3z/EwnKnRfuDIgnmFykZZ6W/6Vi1jFCHenBxZ/23KHbdaJ8/4F/Z X-Received: by 2002:a05:6402:278a:: with SMTP id b10mr51657249ede.54.1625100766539; Wed, 30 Jun 2021 17:52:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625100766; cv=none; d=google.com; s=arc-20160816; b=GGYIOTs8SN0L1Fwa0UbhbTwdOoYQM9xxCc40fcnJalD8prdD/VmoJRWOpUEzVlTTtn qKIFXFE+2ZRHNWrXXSNzIG9EG6ERMGgK15C0dRv405OOn/hLCI1vKsupSwA8cWY1hp0J nQoqT0feZHOmSCiv4MdZGjD1C5X+rVMewGxplafpiG8yqNi9CmJ11ghrooRDG4Ub146u zhAa8xdh5yf5DrEnXPcq2SRWktXY/6Yf2lGMYpDvv+F8eY6AhVzePBbcQ51dZqBnmCya mEtE8T+MUgEAItIPLS9I/Q7RBd/CECAEM/hbXI505j8+JhSPT/zQzxovoVZmlqTqowl/ WxLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PEkTkME5tdMJ63s9VLlI+BOUS13RIAMPOHDqhkJdFkw=; b=wcwups5xCJIkgCFDeD97JVmq5Hx2h5rl6eZKD67adwBYE59L9LXaQSxFGKDYCvU0Pi w6oe1WvUf5op32GD8Jh6CdQ6KeDNRTfYKvuizYwaV2r2COphy/OxBJVmwSWpdzh72xpF VylYuxPu73ASgdsHRgie5RsUXU/E7NdhN6CtYGmiZr4H6Crp8K0dCb3yrLQENuKcCSbd uaiFrK0/r9p2gayoVTpFeu3Eq4NzeY1V7VgM3m5oAyi4GegqHtOmLxlCWvpCiYisCxW5 djnBZY/mb1yZVIKhowqq+tles3baDOACTkIYaD/Ayio5JrvN6hRquF1V/i7YLhCNY4Xi maMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TnOGqyrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hv7si17321520ejc.15.2021.06.30.17.52.23; Wed, 30 Jun 2021 17:52:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TnOGqyrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235571AbhGAAxy (ORCPT + 99 others); Wed, 30 Jun 2021 20:53:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:57552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbhGAAxw (ORCPT ); Wed, 30 Jun 2021 20:53:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D010F61424; Thu, 1 Jul 2021 00:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625100682; bh=H6cuf8ISy4DjCGDDE+uMRILESFmwFtgKYDwCMkBmIe4=; h=From:To:Cc:Subject:Date:From; b=TnOGqyrt2022ci9TMZUZP7qK1iYtZKvcXz4XLXj9I2T9NcxIkFw7SzpWVZFDWrQou 5n0TOLegXmAM03lGZRHDaNJq09cInU1P2byukJRNq3Lu/F+bNT+mIex2WUWmKmcKng CZIE+I/xtHMvi+oJWn+4BT+7BYWTtrsMBOyUbfMDCZQSk8fzht57IMmM4I7F79Kann 1eHy5znBeWw9C6zVNKRPOspRZfOZKm9xusJRLX6owdBKtUaKH9D5qTsFRuOsgYGQax 2TdpkYS9W89pGIO5dUcUl01YcpUnc0MvMg+mgO7br2R+4S4h15FMwOk2knTnY7moAr CeuJg+3dmNi5g== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Cc: Jaegeuk Kim , Stanley Chu , Can Guo , Bean Huo , Bart Van Assche , Asutosh Das Subject: [PATCH] scsi: ufs: add missing host_lock in setup_xfer_req Date: Wed, 30 Jun 2021 17:51:17 -0700 Message-Id: <20210701005117.3846179-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds a host_lock which existed before on ufshcd_vops_setup_xfer_req. Cc: Stanley Chu Cc: Can Guo Cc: Bean Huo Cc: Bart Van Assche Cc: Asutosh Das Fixes: a45f937110fa ("scsi: ufs: Optimize host lock on transfer requests send/compl paths") Signed-off-by: Jaegeuk Kim --- drivers/scsi/ufs/ufshcd.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index c98d540ac044..194755c9ddfe 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -1229,8 +1229,13 @@ static inline int ufshcd_vops_pwr_change_notify(struct ufs_hba *hba, static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba *hba, int tag, bool is_scsi_cmd) { - if (hba->vops && hba->vops->setup_xfer_req) - return hba->vops->setup_xfer_req(hba, tag, is_scsi_cmd); + if (hba->vops && hba->vops->setup_xfer_req) { + unsigned long flags; + + spin_lock_irqsave(hba->host->host_lock, flags); + hba->vops->setup_xfer_req(hba, tag, is_scsi_cmd); + spin_unlock_irqrestore(hba->host->host_lock, flags); + } } static inline void ufshcd_vops_setup_task_mgmt(struct ufs_hba *hba, -- 2.32.0.93.g670b81a890-goog