Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp209352pxv; Wed, 30 Jun 2021 18:54:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/KjkVPcwZBBU1S61AATAiX6YoFExcEXFXLOK0dduGQfbK/MrRCCY4oZP5xiPiB0v7NDUq X-Received: by 2002:a02:1d86:: with SMTP id 128mr11472126jaj.106.1625104470540; Wed, 30 Jun 2021 18:54:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625104470; cv=none; d=google.com; s=arc-20160816; b=zUDGCgMYedRbPgVmMNCw5/u7ddXsLq87jEdncoFXHRyZB0A6HViXMfGx3kJ6bihoER OjRv64te7MRhoopMTTWO8ZGnRZqELyJOK2A5JvxlB4ikWz6t9clCMQ8TFe8dcxUCVNcU Deqk3wzwUjt2/bUG03KL4wCrv+zLXmebRwkf0kxmXPPszIYj32A9/3kSs6pivOrFt/fG 3/iTtZsYrXzVGYroc2SQIT3mfYXaV6WE85hfcapmZXWE1dIj2K9rrmTyFZnS7PK3Gitq HQLnyffAsmVAifjUa9c7j6LTLJ0k8Wi8J6RXWnv8XbTTB4t0UGgR7Jv7aS99cc2Ne0cp xFMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dmarc-filter:sender:dkim-signature; bh=O3dYctqNkA2iDLlLNcFRYr4tGQrg3CF6yd9KGFfYv5s=; b=fcfkXrX6Touz6CWFVwdhNEsXNqPpzJVcbHQF/I4M0oGNBjvqAotglFcTgwMOlf5cqt hDvsBDVLLW7/jMMoeTAV9cUpfey9urEifhRM9EdBXkoJhB+NPAD70YzA5pZcUHFzs+6U fNAPLGclTD2UCKShB8dtznRuIgIf2OAwGOtdhNbF7yK9o9GnpoLUULbcgXo2hDGR5Dbh 0s4RP9hIvZ1hhRkm5WDYRA2S02tYlWzLzYQlp2FjtA680DnvzWveMzIiU7XKly61TJSw chSs17nLw5/4Qru3taZiaanwmHRfshjcTHdvLD/7kX17RZ6PqaU9uIuAQnT1S8V3Q0YD x7bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=nQ1X2aEv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si29031550iol.44.2021.06.30.18.53.54; Wed, 30 Jun 2021 18:54:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=nQ1X2aEv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238461AbhGABx2 (ORCPT + 99 others); Wed, 30 Jun 2021 21:53:28 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:17348 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238452AbhGABx2 (ORCPT ); Wed, 30 Jun 2021 21:53:28 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1625104258; h=Content-Transfer-Encoding: Mime-Version: Content-Type: References: In-Reply-To: Date: Cc: To: From: Subject: Message-ID: Sender; bh=O3dYctqNkA2iDLlLNcFRYr4tGQrg3CF6yd9KGFfYv5s=; b=nQ1X2aEvsFFPV6lePWyzCfTRlUa8uhv+revXn2xSTDO+OUdHJRM2gSqi8375jh+KPnUjeQI/ XcIMqugrfUZtSan73Ewzhr5yxNRm+ZCp9T5H2pFfPIQrL94RXLTepBtgyh/w/sEcEaiYEyTG dg5I4R00kk1p1UKV1kb/OPRBRSE= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 60dd1f6f3a8b6d0a450185f9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 01 Jul 2021 01:50:39 GMT Sender: hemantk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D42A2C43146; Thu, 1 Jul 2021 01:50:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from hemantk-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemantk) by smtp.codeaurora.org (Postfix) with ESMTPSA id AE199C43143; Thu, 1 Jul 2021 01:50:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AE199C43143 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=hemantk@codeaurora.org Message-ID: <1625104231.10055.19.camel@codeaurora.org> Subject: Re: [PATCH v3 1/2] bus: mhi: Fix pm_state conversion to string From: Hemant Kumar To: Paul Davey , Manivannan Sadhasivam Cc: Bhaumik Bhatt , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 30 Jun 2021 18:50:31 -0700 In-Reply-To: <20210629035357.11091-2-paul.davey@alliedtelesis.co.nz> References: <20210629035357.11091-1-paul.davey@alliedtelesis.co.nz> <20210629035357.11091-2-paul.davey@alliedtelesis.co.nz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote: > On big endian architectures the mhi debugfs files which report pm > state > give "Invalid State" for all states.  This is caused by using > find_last_bit which takes an unsigned long* while the state is passed > in > as an enum mhi_pm_state which will be of int size. > > Fix by using __fls to pass the value of state instead of > find_last_bit. > > Signed-off-by: Paul Davey Reviewed-by: Hemant Kumar -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project