Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <9ba184b3f4781cf68ee953b34ea67fdb678cf10f.camel@fi.rohmeurope.com>
Subject: Re: [PATCH] regulator: bd9576: Fix testing wrong flag in
 check_temp_flag_mismatch
From:   Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reply-To: matti.vaittinen@fi.rohmeurope.com
To:     Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20210623153443.623856-1-axel.lin@ingics.com>
References: <20210623153443.623856-1-axel.lin@ingics.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date:   Thu, 01 Jul 2021 08:19:21 +0300
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Wed, 2021-06-23 at 23:34 +0800, Axel Lin wrote:
> Fix trivial copy-paste typo.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/bd9576-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/bd9576-regulator.c
> b/drivers/regulator/bd9576-regulator.c
> index 8b54d88827be..3023069536ff 100644
> --- a/drivers/regulator/bd9576-regulator.c
> +++ b/drivers/regulator/bd9576-regulator.c
> @@ -294,9 +294,9 @@ static bool check_temp_flag_mismatch(struct
> regulator_dev *rdev, int severity,
>  				    struct bd957x_regulator_data *r)
>  {
>  	if ((severity == REGULATOR_SEVERITY_ERR &&
> -	     r->ovd_notif != REGULATOR_EVENT_OVER_TEMP) ||
> +	     r->temp_notif != REGULATOR_EVENT_OVER_TEMP) ||
>  	     (severity == REGULATOR_SEVERITY_WARN &&
> -	     r->ovd_notif != REGULATOR_EVENT_OVER_TEMP_WARN)) {
> +	     r->temp_notif != REGULATOR_EVENT_OVER_TEMP_WARN)) {
>  		dev_warn(rdev_get_dev(rdev),
>  			 "Can't support both thermal WARN and ERR\n");
>  		if (severity == REGULATOR_SEVERITY_WARN)

 Once again, Thanks a lot Axel!

Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>