Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp462221pxv; Thu, 1 Jul 2021 02:05:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxThgvVwcn+cm13Jot5x7zTmgYL5A00Bg+BKhaaT8gR0ui4BeCteHSJ+kbzRGJRxM5jek5q X-Received: by 2002:a02:620a:: with SMTP id d10mr13090930jac.22.1625130330641; Thu, 01 Jul 2021 02:05:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625130330; cv=none; d=google.com; s=arc-20160816; b=VhN6zqJr8zr2xQlz888lNy22j/YUzBp2PJqJdCFnFIK6eazUeYdbMRqk7USqDNopaL Kt3Grpjy7ITmo4Q63nuah8Req8ndYSWeJM/bbOxKARIxxDGgOwBrF3otdeElF/Cmq9g5 3bmYRrp5eznJ8+JHXiuDoOtHDWgCQu0Qzv05bATtD79FPa/VQ6vjmAzuBVQyxFjXFJuU ZkorBaiGLynldCfMzeWskgcfre1/Ry//9Umg7Vz2ilZKibNJO5/si+vScJtjbuzx22nI jDwgqOwHYdTmQVbeN+BW7ndCeTPgKBjk8QEbsv/rrGzMB3pQkHBSq781KvYvAc0Ox6hK jGVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=29szjainBgTUK8YorSbMrEy5VtMXul4IruPxPqTOXeI=; b=FgIb0HeAQ5sYddyUDKNwDKbVx/YcRNSw7+0MR8IItsbDQ1svivXCC6oqY/pV8xdLVW m3B+x8vtKsetVkkLTnNVkGXG6IhZGfHwCIYT7IoNMo8iXUN3qQ3Tx/CtLBW3OqVDvIwh fbhRS/x7vnwlgF759kzVV2MIAy7YqWSymbtdzBxFLCqkmBOT5mexOKmrst++RhcH6GiC QhYkbQPsf40UxOp6nN1BFSjNKMuEYk2BwNeNj+magEGvP3vnKeBJzidm01jB+cvrfiSx 9t9Cg6pM4/1/KGByN+I4Hv+tJ1Pj4J/Knq7ojHD6g8S9HRUtrjIqjxPZsu8SG5lX4PD3 MXaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=W+MHrbur; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r9si129067jad.24.2021.07.01.02.05.17; Thu, 01 Jul 2021 02:05:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=W+MHrbur; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235691AbhGAJHB (ORCPT + 99 others); Thu, 1 Jul 2021 05:07:01 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:49289 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235626AbhGAJHA (ORCPT ); Thu, 1 Jul 2021 05:07:00 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16193FJ0017994; Thu, 1 Jul 2021 11:04:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=selector1; bh=29szjainBgTUK8YorSbMrEy5VtMXul4IruPxPqTOXeI=; b=W+MHrburyVHvTHj+5P+fuvEoLKrNA+969v6JCIy9qw0tbw1gVgNmNsysx1AUZaI8u6bn 2s+ioWcvh+9IFbB4hbiD8bJAJw5g8gzqQbbmsmh2JU3lC0C66XQHjGB2GtcWOZxdLX1A ndrNw9bz0FKah+bCshVmE1JAuYXrxuEaeXzuGcV21kr+1oeewKq/xx8E8fYFWrVWTFJX RXuRifXkiQoEI6miEsectvmDuvq6RAePJlWqWvvyVMMFJkxGzTBP/x4l7JxkbJOL9LZK eKTsCuuxlNrj5jsgzAFuCKCx0vHC05L03kS/5j5rEnMdIFE6mtJXvbIWRYItT6AOt/08 vQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 39h9qe8j4m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jul 2021 11:04:23 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3EF9B100034; Thu, 1 Jul 2021 11:04:23 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 2D5402138C8; Thu, 1 Jul 2021 11:04:23 +0200 (CEST) Received: from localhost (10.75.127.44) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 1 Jul 2021 11:04:22 +0200 From: Arnaud Pouliquen To: Bjorn Andersson , Ohad Ben-Cohen , Mathieu Poirier CC: , , , , Subject: [PATCH v3 1/4] rpmsg: Introduce rpmsg_create_default_ept function Date: Thu, 1 Jul 2021 11:04:10 +0200 Message-ID: <20210701090413.3104-2-arnaud.pouliquen@foss.st.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210701090413.3104-1-arnaud.pouliquen@foss.st.com> References: <20210701090413.3104-1-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-01_06:2021-06-30,2021-07-01 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By providing a callback in the rpmsg_driver structure, the rpmsg devices can be probed with a default endpoint created. In this case, it is not possible to associated to this endpoint private data that could allow the driver to retrieve the context. This helper function allows rpmsg drivers to create a default endpoint on runtime with an associated private context. For example, a driver might create a context structure on the probe and want to provide that context as private data for the default rpmsg callback. Signed-off-by: Arnaud Pouliquen Reviewed-by: Mathieu Poirier --- update from V2: - fix typos. --- drivers/rpmsg/rpmsg_core.c | 51 ++++++++++++++++++++++++++++++++++++++ include/linux/rpmsg.h | 13 ++++++++++ 2 files changed, 64 insertions(+) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index e5daee4f9373..196f922be3e1 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -115,6 +115,57 @@ struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev, } EXPORT_SYMBOL(rpmsg_create_ept); +/** + * rpmsg_create_default_ept() - create a default rpmsg_endpoint for a rpmsg device + * @rpdev: rpmsg channel device + * @cb: rx callback handler + * @priv: private data for the driver's use + * @chinfo: channel_info with the local rpmsg address to bind with @cb + * + * On register_rpmsg_driver if no callback is provided in the rpmsg_driver structure, + * no endpoint is created when the device is probed by the rpmsg bus. + * + * This function returns a pointer to the default endpoint if already created or creates + * an endpoint and assign it as the default endpoint of the rpmsg device. + * + * Drivers should provide their @rpdev channel (so the new endpoint would belong + * to the same remote processor their channel belongs to), an rx callback + * function, an optional private data (which is provided back when the + * rx callback is invoked), and an address they want to bind with the + * callback. If @addr is RPMSG_ADDR_ANY, then rpmsg_create_ept will + * dynamically assign them an available rpmsg address (drivers should have + * a very good reason why not to always use RPMSG_ADDR_ANY here). + * + * Returns a pointer to the endpoint on success, or NULL on error. + */ +struct rpmsg_endpoint *rpmsg_create_default_ept(struct rpmsg_device *rpdev, + rpmsg_rx_cb_t cb, void *priv, + struct rpmsg_channel_info chinfo) +{ + struct rpmsg_endpoint *ept; + + if (WARN_ON(!rpdev)) + return NULL; + + /* It does not make sense to create a default endpoint without a callback. */ + if (!cb) + return NULL; + + if (rpdev->ept) + return rpdev->ept; + + ept = rpdev->ops->create_ept(rpdev, cb, priv, chinfo); + if (!ept) + return NULL; + + /* Assign the new endpoint as default endpoint */ + rpdev->ept = ept; + rpdev->src = ept->addr; + + return ept; +} +EXPORT_SYMBOL(rpmsg_create_default_ept); + /** * rpmsg_destroy_ept() - destroy an existing rpmsg endpoint * @ept: endpoing to destroy diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h index d97dcd049f18..11f473834e86 100644 --- a/include/linux/rpmsg.h +++ b/include/linux/rpmsg.h @@ -172,6 +172,9 @@ void rpmsg_destroy_ept(struct rpmsg_endpoint *); struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *, rpmsg_rx_cb_t cb, void *priv, struct rpmsg_channel_info chinfo); +struct rpmsg_endpoint *rpmsg_create_default_ept(struct rpmsg_device *rpdev, + rpmsg_rx_cb_t cb, void *priv, + struct rpmsg_channel_info chinfo); int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len); int rpmsg_sendto(struct rpmsg_endpoint *ept, void *data, int len, u32 dst); @@ -234,6 +237,16 @@ static inline struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev return ERR_PTR(-ENXIO); } +static inline struct rpmsg_endpoint *rpmsg_create_default_ept(struct rpmsg_device *rpdev, + rpmsg_rx_cb_t cb, void *priv, + struct rpmsg_channel_info chinfo) +{ + /* This shouldn't be possible */ + WARN_ON(1); + + return NULL; +} + static inline int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len) { /* This shouldn't be possible */ -- 2.17.1