Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp468900pxv; Thu, 1 Jul 2021 02:15:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM6E9q1dHNBoeuH8PYLphssVQ76BafhpneCIT3rfshmZXm6stEB7YwVhhhj5QnaM8m6f71 X-Received: by 2002:a92:a806:: with SMTP id o6mr5848547ilh.53.1625130933338; Thu, 01 Jul 2021 02:15:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625130933; cv=none; d=google.com; s=arc-20160816; b=JnmKS6zHtt/l4+2R9AfR4y4G0xdNNMpWkodNY6h9WAZfQeE0AxGsMHWZMXjsNynQ4i dmzhtttbKMvOpnGWeelhHytXHs2TMhf4q94CM2qJ6fDDQl+TKBOPa6H9ktvecTtofJ3h hXAVL02fjALXEY/eh8gNrnghRag8uJU+odtZoQuvQHpgfbeT+LU4T26caYk1WNyEZ0zJ wgjA4AI8ce4jBDIZY5Gzk/gBtzO3U9ytYiGTr45baHS0z/oPh5jRkadvC8mcvfNrnndh v9gND/p9ul1SVa83FH4IlZzBvPFl4dabM16+T2wtVHwboCEllm0KcfNelyehrhEZQGyk lQPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from; bh=Q9/fqvpbjKgQMRg7iZrW6B8O8Uu9VdWOniL08X6W/aU=; b=FeRWmoUsN2CO5Vb94QASBwPyhgWfRxXBVczTIuAqT4jhTTQHa6AmYtmYlH7YmEwZGt 0PiOzjZm+F+GRPoIyubZ3Czwr8GghTT9QzWm80JTaNvVQggKCK/r0jofpVbIbx6cgO0i AMxWY4GhI3rrmcwM8/Pd+iihAU4XnTnfAdRzueJsUaAjYDrmbqdvvKFp4+TnrTZy35Xv onPk2idZfRXLhoCXp1mmKocgTW/tvf2qFeEcOFv7wLrzDvV40WXUb8XcKTar9PcXkwll ufXvt04iJmGgIYHUA2Oa/hjzJqsEylDQTPu+SDESnpC9dwiynIxamZKiMPcEY9GIgYij sRNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si16393114ile.35.2021.07.01.02.15.19; Thu, 01 Jul 2021 02:15:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbhGAJRP (ORCPT + 99 others); Thu, 1 Jul 2021 05:17:15 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56492 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235654AbhGAJRO (ORCPT ); Thu, 1 Jul 2021 05:17:14 -0400 Received: from mail-pl1-f198.google.com ([209.85.214.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lysmQ-00075M-Q0 for linux-kernel@vger.kernel.org; Thu, 01 Jul 2021 09:14:42 +0000 Received: by mail-pl1-f198.google.com with SMTP id b2-20020a1709027e02b0290128e572ee46so2495948plm.3 for ; Thu, 01 Jul 2021 02:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q9/fqvpbjKgQMRg7iZrW6B8O8Uu9VdWOniL08X6W/aU=; b=Mt1enSmaCuJjz36t2YTEWFhzI1krqlWFO1MGdSBjllg9zicGmmRuQf6qfpI8/FOLZM xcliK6Nc5Mec4EwQYawmosajkBqhtQOTBS5ynLB7xG8V9BRTdzN9Z1g2NBucQjbfeE4f sdRvwz7ggnCHxaXtQmlS+rZb0WvWiwlku9nK4i/GCpIw1axhNhjP35366EH695dwcROH +HPSklJa5xueahPebvUM9IqVV2sbDWL5yu2JJIqk/vpx+Y61Dph0oK2sc2GJ1POdJqrH CCIA9iZfqEQ1L1+MmloMz/P/sT617gAiLXc/B54GxE/js7TkBu8DSt+teE8ZDdAztSJB VqSQ== X-Gm-Message-State: AOAM5330xfuftRV/Urv73ognhNAir/AZ/BlCR6a6UcYGSJ2tMfUbZV8B aRwsjIa1C/N1RQnAtTVK95ga/SC27O6sPDGHYxoo1i2P8aBK93Mz/s9TLMCkCoc8pUMfv0ua0KV fyuLat2Sz472g7auwhd1lwJwkTnXl5UZOWth6kTTqrg== X-Received: by 2002:a62:6447:0:b029:30d:4bba:8b5a with SMTP id y68-20020a6264470000b029030d4bba8b5amr17894358pfb.71.1625130881480; Thu, 01 Jul 2021 02:14:41 -0700 (PDT) X-Received: by 2002:a62:6447:0:b029:30d:4bba:8b5a with SMTP id y68-20020a6264470000b029030d4bba8b5amr17894332pfb.71.1625130881287; Thu, 01 Jul 2021 02:14:41 -0700 (PDT) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id c14sm18133190pfj.205.2021.07.01.02.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 02:14:40 -0700 (PDT) From: Andy Chi Cc: andy.chi@canonical.com, Jaroslav Kysela , Takashi Iwai , Kailang Yang , Jeremy Szu , Hui Wang , Jian-Hong Pan , Chris Chiu , Huacai Chen , Sami Loone , Werner Sembach , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/3] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8 Date: Thu, 1 Jul 2021 17:14:14 +0800 Message-Id: <20210701091417.9696-2-andy.chi@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210701091417.9696-1-andy.chi@canonical.com> References: <20210701091417.9696-1-andy.chi@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The HP ProBook 445 G8 using ALC236 codec. COEF index 0x34 bit 5 is used to control the playback mute LED, but the microphone mute LED is controlled using pin VREF instead of a COEF index. Therefore, add a quirk to make it works. Signed-off-by: Andy Chi --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6c423172a1f4..949c8e5ac54a 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8372,6 +8372,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8862, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), + SND_PCI_QUIRK(0x103c, 0x8863, "HP ProBook 445 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT), -- 2.25.1