Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp626704pxv; Thu, 1 Jul 2021 06:03:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn3Dl+2oi07kDT9B+hnB9J+kg46QhzjvetA3/zwfQad3w2A/gtXMQ8oS6swFFv1Pp1weBH X-Received: by 2002:a05:6402:748:: with SMTP id p8mr54293519edy.91.1625144597821; Thu, 01 Jul 2021 06:03:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625144597; cv=none; d=google.com; s=arc-20160816; b=f0/+G7WxvdDXRu5Xp5Zv/XrjmA12owoJPQKjig6NbVzblPliMCu2pscDD7tcrlZJi/ eRyulON10IpTLb9nzEAa7wgASs+CXmbGPHBU5Q0Rl6PJA2jZ4XXBv0vBoGsmUskgDMiK KypSt9P6UrTVENo4sTA08dE0qWHt9tjd/o9BO9CbWisOkAP5bkELiRFZQcuLDasMoL+B vgdV6ddF0ZSXRq1jBLAgguzH8NznmMAHIX+tNddc/n5N5YHkGrtVJwND8vtoho0i8yIH ujc0c7A7ekruQhPM+Iw90ZdFOHAPTvALuJBqcuKd+djjW41DMa/Onfw7b4pnaA1b/Tma ugfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LP1zw9D1kU9DP50D5jN5AmF+x1tEmTJj8I96Pc25WU4=; b=isu4FafhZ+8yWeIVslgDZ1WvHXqr/QSX1tia4tQfJSfmLn6nzZ7+2HSTn+x7NaVgCl cflN5xROlxL+fkZSeKOVTDR/Z2H/YbQ+wEmS2f3g4VTXCX52mtVN8I7lkq7tKubAHyoY 4lJfATX3QnaMlCWVd5lNGGNV+2koGVrwynWMVV7iKJ7FjO/p470O5JCoM2gzMPdj6v/w AZtDFkNo31jZyPqY8u93wKNDMqhT4cYFFlPukZ5OKCWyomi8lC72iUiDyT90r1NWo0Wh eUm8vhz4mMSjYlxm6L+pAPhOo5g6Xx/9Ua9yqxoE1wA+cl7pkc9sQXnv0qdIAV7CWVde t7Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gI7SJdQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eo22si10775597ejc.594.2021.07.01.06.02.54; Thu, 01 Jul 2021 06:03:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gI7SJdQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236455AbhGAND0 (ORCPT + 99 others); Thu, 1 Jul 2021 09:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236609AbhGANDB (ORCPT ); Thu, 1 Jul 2021 09:03:01 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF8CAC0613A2 for ; Thu, 1 Jul 2021 05:59:01 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id b14-20020a17090a7aceb029017261c7d206so813425pjl.5 for ; Thu, 01 Jul 2021 05:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LP1zw9D1kU9DP50D5jN5AmF+x1tEmTJj8I96Pc25WU4=; b=gI7SJdQ7wg1lgzynuAr9lL8WzUyoXSAjQ05lrp7Cvw1p+Rr55+i5TVBPS89Fg6ffq9 HrFoUOrQ2sRYuv/p+3jxRIeLDEQ/soS13C+nyZHt0yhDP/pAlXak939aLX55oLj3wZEX uDNomBhFCvUz72GJWCwi4gJLS7pwBGYvChKlgetSUZ1zVrE8qW8Z8VAcFn/aolRLQ8Lv +kvzVQ4Jl/MV7OjiOYANqabQzaqPD6Ok8SV6eNxC8nO5OKSuK5m3K7YLcQcZuw+akdto ZeGl5bDrTvqEQ0j9CPpdxtenu9X0arUBtwF80SinIB2Z8pb7QTvUySx1gBbc0HN9Uq9i pi+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LP1zw9D1kU9DP50D5jN5AmF+x1tEmTJj8I96Pc25WU4=; b=VHYQeT7IWknsxCGslC4uCAANvsoH5Rf22rtUy3nTWHAoLXzmOV1MyiVH+vv+F4njOP UO1LPrUSnf/Gqb+id3BlBWVsuhjlXe7pekfCzMMF5cmxSM0IOIb5hRUEUSe8av+rPbyU PSxI3jFjpHn8hs36+pCcJYNbufkLUH9NpvpF0MLGy8Vw7M6ur2Ebtlr7vz3pqJq8MBFy 5hY/AsOncu0QJ/DQNwSNsS5IYcsud3fziuae3krOLmJpS+Gn4okdGG8yA8RlMnmBUFv7 HgU4P5DZKgY6UGJeHpNHXzgpS17pjb9j1eoOFeW1xG4bRNFAIN62kdazPCgq331jYh8t QSaQ== X-Gm-Message-State: AOAM533N2YEfMu7NEn/sZUR3Q/7R2O1E2G8bw8Cyym3u85qt6DvkRHhd BYmiYjrdUlkUuOW3MkYTqeTWgXFjifY8IyL2pi4= X-Received: by 2002:a17:90a:540d:: with SMTP id z13mr46566490pjh.159.1625144341362; Thu, 01 Jul 2021 05:59:01 -0700 (PDT) Received: from ubuntu.localdomain ([218.17.89.92]) by smtp.gmail.com with ESMTPSA id r10sm26971191pga.48.2021.07.01.05.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 05:59:00 -0700 (PDT) From: gushengxian To: linux-kernel@vger.kernel.org Cc: gushengxian Subject: [PATCH] tools lib traceevent: avoid memory leak: buf Date: Thu, 1 Jul 2021 05:58:53 -0700 Message-Id: <20210701125853.710636-1-gushengxian507419@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: gushengxian buf is realloced so free(buf) should be added to avoid memory leak. Signed-off-by: gushengxian --- tools/lib/traceevent/trace-seq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/lib/traceevent/trace-seq.c b/tools/lib/traceevent/trace-seq.c index 8d5ecd2bf877..deafb773087e 100644 --- a/tools/lib/traceevent/trace-seq.c +++ b/tools/lib/traceevent/trace-seq.c @@ -87,11 +87,13 @@ static void expand_buffer(struct trace_seq *s) buf = realloc(s->buffer, s->buffer_size + TRACE_SEQ_BUF_SIZE); if (WARN_ONCE(!buf, "Can't allocate trace_seq buffer memory")) { s->state = TRACE_SEQ__MEM_ALLOC_FAILED; + free(buf); return; } s->buffer = buf; s->buffer_size += TRACE_SEQ_BUF_SIZE; + free(buf); } /** -- 2.25.1