Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp719883pxv; Thu, 1 Jul 2021 07:52:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9z/J0Mph/Sn8umxFUi0gXOBkm2wstDxseJ8tc05T5tMzpJyFQIZFzUO0ihaY1292dK7Ck X-Received: by 2002:a05:6402:28a1:: with SMTP id eg33mr247342edb.249.1625151147939; Thu, 01 Jul 2021 07:52:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625151147; cv=none; d=google.com; s=arc-20160816; b=urUiwXaYhvpPusyr+y8Qc5TLcDvgqJRi5RIOCk4Jhq2kLradpUSggsezQDM92Aaszb tK6lgruSe/syJzJZhW2ABpRz2O/oxXfR5QEyRUNYpP5+1niOni9pGo6i8C57Vx37cLvc zdenJ9dUk3QpAQlRGSbPkOOb5Xl6ljOMLPDum/f2gcUhX5BF/POaxqa60MPxyWHhUxv7 OxQQPBzO+gJc1S7J5bBIH8hCOjepYHA62O6viV0AGMq/LIaBE0FbCacKPhShaJG96XL5 txyxQ4iE/gfL/S4CWpnzoSzb4NEU7hCspkJ8kuan9xcIKfjBCDl8Z6OYsFgG2QpdbVV+ JtRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JKzt46NlE/OClzyqd5L8qkhPno3gsENpKKVZIXqgBLM=; b=r+fg6CqQN80jDpOkZ750OzG7ajRyQd/mbprghkEVKPpR/D/PyTJdB/ilRuGYo8orpP jlCEaZuMgOnu01PRoCRwGXanWjqj/YxpsL8kak8koCGKs5mQTbWUKzTVGVMzH9slic62 5uLhKaM49mpfbujylN7241vGvl4SZBgP46RRpQW6kx/uGlsHTbyopyd/GzbG9wRpU+za mq7pwak3dE70rSrdgqZZA7MkK/W8Jl1iTmHmTvAeHJopyWQhCpC/RJ4AiBbstutql64y EKPhGIb6NrKHysBUeiaBYKuTEMXin+u+pUgupNNmagvtzzrjwz+QUrjlv0yu2Jo4YvYp /3Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=r7T6Gbpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s21si162332ejy.697.2021.07.01.07.52.02; Thu, 01 Jul 2021 07:52:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=r7T6Gbpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232566AbhGAOw7 (ORCPT + 99 others); Thu, 1 Jul 2021 10:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbhGAOw7 (ORCPT ); Thu, 1 Jul 2021 10:52:59 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFD75C061762; Thu, 1 Jul 2021 07:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JKzt46NlE/OClzyqd5L8qkhPno3gsENpKKVZIXqgBLM=; b=r7T6GbpghOx3fktE2bmkIi2N1q /rVRSO+kYNfI4KG2tzsa3J5i72e5Pz2ms7+WokBMFUwRJdvrIco/3tsDe/yZeECiRAFtHxzA49+pO Gc/6PNHWuV9Pn3o2iye7dcpr+7dkgcrfrFJW39KUGHs/n4DpWv2051zcmB7D219ICwjmCN3cKDVR1 nXCMbfU4gDQW+ZQkcgniKXqlg8yRwYM/M4PnG3Cas89djZVw2TuH3lwNzhWJGHJyZ/Z+uI9RaltO2 TlQ2Z3XEPTPcWE9EZ1bQrMlID8fN5G6DpD6qZMEsaYhBNXAzk8ph2mx3YPWals1DkUm5/Pd+x8roo 4soZ3raQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyy0l-006fTq-1V; Thu, 01 Jul 2021 14:49:59 +0000 Date: Thu, 1 Jul 2021 15:49:51 +0100 From: Christoph Hellwig To: Martin Kepplinger Cc: bvanassche@acm.org, jejb@linux.ibm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, kernel@puri.sm, stern@rowland.harvard.edu Subject: Re: [PATCH v5 2/3] scsi: sd: send REQUEST SENSE for BLIST_MEDIA_CHANGE devices in runtime_resume() Message-ID: References: <20210630084453.186764-1-martin.kepplinger@puri.sm> <20210630084453.186764-3-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210630084453.186764-3-martin.kepplinger@puri.sm> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 30, 2021 at 10:44:52AM +0200, Martin Kepplinger wrote: > + struct scsi_disk *sdkp = dev_get_drvdata(dev); > + struct scsi_device *sdp = sdkp->device; > + int timeout, res; > + > + timeout = sdp->request_queue->rq_timeout * SD_FLUSH_TIMEOUT_MULTIPLIER; Is REQUEST SENSE reqlly a so slow operation on these devices that we need to override the timeout?