Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp795488pxv; Thu, 1 Jul 2021 09:22:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVjRfc32jVAFCCie2facxjGQI6b0S3yMsK1CYxXSnRqXqr//xGIohevCl5RqGgWKb1jPRv X-Received: by 2002:aa7:d309:: with SMTP id p9mr871105edq.340.1625156579598; Thu, 01 Jul 2021 09:22:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625156579; cv=none; d=google.com; s=arc-20160816; b=h2Di05XQKYocHd6L7HLjPbZRp+tHvQYwoEuMsCXrvO1SPDxWw8jWtqsOnuT9C5twK0 E1Bz9VjEZBFY1o05Ti4w9n6GzBPaCszQ8p/Rze48Wn9bWW0Gqm2OayYwep2rVyQDRi7P KOLlOggcI1FbnGAzq5Nk50UtXkqXBzM5VAiK33F2zZvVhNFkQhPLcfnMZ1MtbFO2rP5o homaDxU6vciawdsEP7bwweFNsRPWdY7YVzTGAaxa/nven1X2DMcxdQQb/5CsrLhRRr/q JpsrhXgAIxIgTLl63w7J6dSIa9g4aTRCPbqSFrPjsqhgW+PLnyCFBClB6fY3mGvo9iLb nB1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=brRBtSWPzl3A8EO3IIUcfNsjS22D/ywhnA28QnZfB6M=; b=gYoM35+5wI+6i0TA3LXfbp1a0fV3QuNStNuZvR8ybwncajv5mqzop6SeAGwgpXVu+b b455K/iuG7nm1FeiWSy9EbVFFiPrnqgVYFJ3rtn42hB9WB2ipY2ZyXvIS4RJ0GuNq6T/ I1e+OAa2Q3gWn/8nGXUfN8pGx85EbCvH6fiWiDiRcPETkJLEtGk1/iZfCZv7ZploSWQ0 HrXKI94RrvNFnMQyb3XRk87WgfQ45X6xUVzWUUsgUteCTpTJvCffuTKiQqLem7poBNKl cO2578wlkPRn+S3ieZhndKs/OBKLrOuOgXn81s7MTakpyho6ur4s1NQqxR7q0TCrmiLy MNJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=d1+9kxcL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si81338edb.403.2021.07.01.09.22.35; Thu, 01 Jul 2021 09:22:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=d1+9kxcL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232373AbhGAQWu (ORCPT + 99 others); Thu, 1 Jul 2021 12:22:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231998AbhGAQWs (ORCPT ); Thu, 1 Jul 2021 12:22:48 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF2DEC061765 for ; Thu, 1 Jul 2021 09:20:16 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id w11so9337902ljh.0 for ; Thu, 01 Jul 2021 09:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=brRBtSWPzl3A8EO3IIUcfNsjS22D/ywhnA28QnZfB6M=; b=d1+9kxcLWBvJSpk3fPYeulpwABLezPQJEk+Zy5DmBCHiV5k8fys4vw9rA6zQazJKc2 axsZXI/dx/8bY1setfHEYMO0trSZO9E1jscAwqkUc35Jb6iAXsIo7AKCKK+UvXc4yq3e qiMCd+A5iPA4rWbSxd7fv0SiZp5q2XVbT5RkihF/c9RqhFql0Y9/wfOxBCtfxgXbFAMr Mx7KUZrtHN63OOzj6Yug9Kv/mnaN8sHZt8YTIbHepTjFUeytb0b2nHtfQ8RV40xMkSSe 5qtgbQrElgjEnzp0Iq1NHO5GO/OXxxgwKceI1RgUEbvxexDjJYgB8i2ImLpq/VwKKJNu X9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=brRBtSWPzl3A8EO3IIUcfNsjS22D/ywhnA28QnZfB6M=; b=CfbPzsuFXZSL+wmYaIEi7PF1lctyDJBj13Q4/g0cMeYnP/ojZDt9qXTvish+976/LB uqw1TvfEj0yauRKWQLv0SUtHYT+MJxjjxmrwG8C+Bar0wsT6FI533Q8yzqKeB7sSBYkR LcgWYnn3ZHwe1s9d09fl4ba2F1+ZulQpazu0P/JM+PMH6Wb4Rf4Nozj9UDnV87Eh9o/r wvfTWDk6rtEouBV/jgUXLbdhlrybkcLDhWXne2jF9dMvIjqdHZHycQsSp7MWJ0hrnyeA sGNDoIC4VLWtTDqDcb72RS0hhhmJCfXeP6d9qo7ewigqE30m5ZlEt22D/fZicoy4TXYj 1gkg== X-Gm-Message-State: AOAM531UTXpFSUDgRz1E682zIi4kqvyjTRrNlywWzA1IFjpt1c3KDlS3 54vr40QYFAxPY9TVfS/bi9P5nS2jGnXxMvrhMXKTpQ== X-Received: by 2002:a2e:b4ce:: with SMTP id r14mr319557ljm.76.1625156414497; Thu, 01 Jul 2021 09:20:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jeroen de Borst Date: Thu, 1 Jul 2021 09:20:03 -0700 Message-ID: Subject: Re: [PATCH 0/3] gve: Fixes and clean-up To: Christophe JAILLET Cc: csully@google.com, sagis@google.com, jonolson@google.com, davem@davemloft.net, kuba@kernel.org, awogbemila@google.com, willemb@google.com, yangchun@google.com, bcf@google.com, kuozhao@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 30, 2021 at 10:58 PM Christophe JAILLET wrote: > > This serie is part of the effort to axe the wrappers in > include/linux/pci-dma-compat.h > > While looking at it, I spotted: > - a resource leak in an error handling path (patch 1) > - an error code that could be propagated. (patch 2) > This patch could be ignored. It's only goal is to be more consistent > with other drivers. > > These 2 paches are not related to the 'pci-dma-compat.h' stuff, which can > be found in patch 3. > > Christophe JAILLET (3): > gve: Fix an error handling path in 'gve_probe()' > gve: Propagate error codes to caller > gve: Simplify code and axe the use of a deprecated API > > Thanks for these patches. Can split this into 2 patch series; one for net (with the first 2 patches) and one for net-next (with the cleanup one)? Also the label in the first patch should probably read 'abort_with_gve_init' instead of 'abort_with_vge_init'. Jeroen