Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [v11 01/19] dt-bindings: ARM: Mediatek: Add new document bindings
 of MT8192 clock
To:     Chun-Jie Chen <chun-jie.chen@mediatek.com>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc:     Stephen Boyd <sboyd@kernel.org>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>, linux-clk@vger.kernel.org,
        DTML <devicetree@vger.kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        Project_Global_Chrome_Upstream_Group@mediatek.com
References: <20210630132804.20436-1-chun-jie.chen@mediatek.com>
 <20210630132804.20436-2-chun-jie.chen@mediatek.com>
 <CAAOTY_8SgZ5SN9Q0nfL_jQVTbB7ZDqgoGFRkKe8+QJwUi55Hew@mail.gmail.com>
 <da0db357ac7e41ca6ec2007eccccbb465049cd01.camel@mediatek.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <775b61ab-8a23-ab78-f7a8-11d09d7ded3f@gmail.com>
Date:   Thu, 1 Jul 2021 19:30:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <da0db357ac7e41ca6ec2007eccccbb465049cd01.camel@mediatek.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 01/07/2021 04:13, Chun-Jie Chen wrote:
> On Wed, 2021-06-30 at 22:30 +0800, Chun-Kuang Hu wrote:
>> Hi, Chun-Jie:
>>
>> Chun-Jie Chen <chun-jie.chen@mediatek.com> 於 2021年6月30日 週三 下午9:30寫道：
>>>
>>> This patch adds the new binding documentation for system clock
>>> and functional clock on Mediatek MT8192.
>>>
>>> Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>
>> [snip]
>>
>>> +
>>> +  - |
>>> +    mmsys: clock-controller@14000000 {
>>
>> mmsys is a system controller rather than clock controller, isn't it?
>>
>> Regards,
>> Chun-Kuang.
>>
>>> +        compatible = "mediatek,mt8192-mmsys";
>>> +        reg = <0x14000000 0x1000>;
>>> +        #clock-cells = <1>;
>>> +    };
>>> +
> 
> Thanks for you reminder, I will move mmsys to system clock controller.
> 

The mmsys should be documented in mediatek,mmsys.txt

Regards,
Matthias