Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\))
Subject: Re: [PATCH v2 0/3] hfs: fix various errors
From:   Viacheslav Dubeyko <slava@dubeyko.com>
In-Reply-To: <20210701030756.58760-1-desmondcheongzx@gmail.com>
Date:   Thu, 1 Jul 2021 10:03:40 -0700
Cc:     gustavoars@kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, skhan@linuxfoundation.org,
        gregkh@linuxfoundation.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Andrew Morton <akpm@linux-foundation.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <ECFAAAB7-2FAE-4049-9B20-081F5E6613B7@dubeyko.com>
References: <20210701030756.58760-1-desmondcheongzx@gmail.com>
To:     Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Precedence: bulk


> On Jun 30, 2021, at 8:07 PM, Desmond Cheong Zhi Xi =
<desmondcheongzx@gmail.com> wrote:
>=20
> Hi,
>=20
> This series ultimately aims to address a lockdep warning in =
hfs_find_init reported by Syzbot:
> =
https://syzkaller.appspot.com/bug?id=3Df007ef1d7a31a469e3be7aeb0fde0769b18=
585db
>=20
> The work done for this led to the discovery of another bug, and the =
Syzkaller repro test also reveals an invalid memory access error after =
clearing the lockdep warning. Hence, this series is broken up into three =
patches:
>=20
> 1. Add a missing call to hfs_find_exit for an error path in =
hfs_fill_super
>=20
> 2. Fix memory mapping in hfs_bnode_read by fixing calls to kmap
>=20
> 3. Add lock nesting notation to tell lockdep that the observed locking =
hierarchy is safe
>=20
> v1 -> v2:
> Patch 1: Consolidated calls to hfs_find_exit on error paths in =
hfs_fill_super, as suggested by Viacheslav Dubeyko.
> Patch 2: Added safety checks, clarified code, and switched from =
kmap/kunmap to kmap_atomic/kunmap_atomic, as suggested by Viacheslav =
Dubeyko.
>=20
> Desmond Cheong Zhi Xi (3):
>  hfs: add missing clean-up in hfs_fill_super
>  hfs: fix high memory mapping in hfs_bnode_read
>  hfs: add lock nesting notation to hfs_find_init
>=20
> fs/hfs/bfind.c | 14 +++++++++++++-
> fs/hfs/bnode.c | 25 ++++++++++++++++++++-----
> fs/hfs/btree.h |  7 +++++++
> fs/hfs/super.c | 10 +++++-----
> 4 files changed, 45 insertions(+), 11 deletions(-)
>=20
> --=20
> 2.25.1
>=20

Looks good.

Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>

Thanks,
Slava.=