Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 1 Jul 2021 15:03:10 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Ian Rogers <irogers@google.com>
Cc:     Riccardo Mancini <rickyman7@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>, Martin Liska <mliska@suse.cz>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf annotate: allow 's' on source code lines
Message-ID: <YN4DXp1u5kvP6AH9@kernel.org>
References: <20210624223423.189550-1-rickyman7@gmail.com>
 <CAP-5=fXWFvcvNOA+wJMSCp2Qz7EVruufvFBLWEXfdezeEJGUTA@mail.gmail.com>
 <f3bf33bfe2365241fc872ca781109f1b69374840.camel@gmail.com>
 <CAP-5=fVxdwOKWN2oOv7+hr2Vr0wD4jzizzK4x4W8jM8bwZ7u-w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAP-5=fVxdwOKWN2oOv7+hr2Vr0wD4jzizzK4x4W8jM8bwZ7u-w@mail.gmail.com>
Precedence: bulk

Em Tue, Jun 29, 2021 at 08:00:31AM -0700, Ian Rogers escreveu:
> On Fri, Jun 25, 2021 at 8:53 AM Riccardo Mancini <rickyman7@gmail.com> wrote:
> > On Thu, 2021-06-24 at 22:37 -0700, Ian Rogers wrote:
> > > On Thu, Jun 24, 2021 at 3:37 PM Riccardo Mancini <rickyman7@gmail.com> wrote:
> > > comment nit, perhaps prefer "closest" rather than "next" due to
> > > searching backward.
> >
> > The backward search is just a fallback in case the forward one finds no asm
> > line, which I believe is unlikely. Maybe it's also impossible, but I don't
> > really know how those lines are generated, so I put a fallback in place.
> > Furthermore, "closest" would imply that a previous asm line could be chosen over
> > a subsequent one if closer, even if the latter is present.
> >
> > Thanks,
> > Riccardo
> 
> Agreed, thanks for thinking about this.
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo