Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 1 Jul 2021 14:12:21 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Paul Burton <paulburton@google.com>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Joel Fernandes <joelaf@google.com>, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] tracing: Resize tgid_map to pid_max, not
 PID_MAX_DEFAULT
Message-ID: <20210701141221.1d0b1fe0@oasis.local.home>
In-Reply-To: <20210701172407.889626-2-paulburton@google.com>
References: <20210701095525.400839d3@oasis.local.home>
        <20210701172407.889626-1-paulburton@google.com>
        <20210701172407.889626-2-paulburton@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu,  1 Jul 2021 10:24:07 -0700
Paul Burton <paulburton@google.com> wrote:

> +static int *trace_find_tgid_ptr(int pid)
> +{
> +	// Pairs with the smp_store_release in set_tracer_flag() to ensure that
> +	// if we observe a non-NULL tgid_map then we also observe the correct
> +	// tgid_map_max.

BTW, it's against the Linux kernel coding style to use // for comments.

I can take this patch, but I need to change this to:

	/*
	 * Pairs with the smp_store_release in set_tracer_flag() to ensure that
	 * if we observe a non-NULL tgid_map then we also observe the correct
	 * tgid_map_max.
	 */

Same with the other comments. Please follow coding style that can be
found in:

   Documentation/process/coding-style.rst

And see section 8 on Commenting.

Thanks,

-- Steve


> +	int *map = smp_load_acquire(&tgid_map);
> +
> +	if (unlikely(!map || pid > tgid_map_max))
> +		return NULL;
> +
> +	return &map[pid];
> +}
> +